From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 1/2] drm/vc4: Account for interrupts in flight
Date: Mon, 13 Nov 2017 16:59:57 -0800
Message-ID: <8760add69e.fsf@anholt.net>
References: <1510275907-993-1-git-send-email-stschake@gmail.com>
 <1510275907-993-2-git-send-email-stschake@gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0041161165=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from anholt.net (anholt.net [50.246.234.109])
 by gabe.freedesktop.org (Postfix) with ESMTP id 1DBD86E7E3
 for <dri-devel@lists.freedesktop.org>; Tue, 14 Nov 2017 00:59:59 +0000 (UTC)
In-Reply-To: <1510275907-993-2-git-send-email-stschake@gmail.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: dri-devel@lists.freedesktop.org
Cc: David Airlie <airlied@linux.ie>, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, Stefan Schake <stschake@gmail.com>
List-Id: dri-devel@lists.freedesktop.org

--===============0041161165==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Stefan Schake <stschake@gmail.com> writes:

> Synchronously disable the IRQ to make the following cancel_work_sync
> invocation effective.
>
> An interrupt in flight could enqueue further overflow mem work. As we
> free the binner BO immediately following vc4_irq_uninstall this caused
> a NULL pointer dereference in the work callback vc4_overflow_mem_work.
>
> Link: https://github.com/anholt/linux/issues/114
> Signed-off-by: Stefan Schake <stschake@gmail.com>
> Fixes: d5b1a78a772f ("drm/vc4: Add support for drawing 3D frames.")

Reviewed and applied this one.  Thanks!

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAloKQA0ACgkQtdYpNtH8
nujSVQ/+IIEj0tqY5WqFsDA0Xmky6zj1g2EMrX7m569tOl6U8WxUC+X0ry8pNtXn
0el8W5ZbkUMQVKMp3+2DQ+uH90flDGigxF3MGudXlp55Xj3CaCM20rGMpb19Cvlp
FLFUG2i7DmsR976Xbz9nT/+1h0x/4URVJmzx5FpP/iYOo4jMkhL2SPLKj0MaZszM
J2uA1pwR3JindSxR5/ETaMPMjyPjDxB0TwBhT9E8y44+eKJ4aiRopfBdx4QQ7HK9
eotcM/rIDzTTXqUZ3AOMKDFrY65bk9jbGMRBl/d2wyH2i8nXcg/0SQmzdwXYn0rZ
rNGCJGtkEjTy0Z1d7tya8VE/ZPNPZ63adnJN5b2xazSNDX6+QIk4jQfYVRKDfI1p
CF6WxJ9VeEj/FNlrcUJREVRdX26U65U1LtSCrns8TRTgA+OXrdaE11RKvud50jDm
WH0JiTDv7ZHBbaQq6XYA4oQK6EOUdbRUMaCG0VGILWGceBRDvwsjBgmMNbHAAOx9
WNBQMvF5d8xvdoENy0gBdupVF8cJlBPidWmWz3EZbreNz8wEQlWXrBPSCSmn6MTx
V2EFi362Gxd48y5Y/5SpvJJ91vB5yw669qmLbmjUilwG+ooUnxhK3RMXCOKMwp4V
iNelfPLkRw0u5XuFDL1a124m0skrJXZYisL+Uhl2lG/0WwmMnig=
=g32n
-----END PGP SIGNATURE-----
--=-=-=--

--===============0041161165==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0041161165==--