From: Javier Martinez Canillas <javierm@redhat.com>
To: Marcus Folkesson <marcus.folkesson@gmail.com>
Cc: linux-kernel@vger.kernel.org, ipedrosa@redhat.com,
David Airlie <airlied@gmail.com>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Simona Vetter <simona@ffwll.ch>,
Thomas Zimmermann <tzimmermann@suse.de>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2 1/5] drm/sitronix/st7571-i2c: Fix encoder callbacks function names
Date: Mon, 14 Jul 2025 17:54:07 +0200 [thread overview]
Message-ID: <877c0a22g0.fsf@minerva.mail-host-address-is-not-set> (raw)
In-Reply-To: <aHTy3tbDKA0QVqBt@gmail.com>
Marcus Folkesson <marcus.folkesson@gmail.com> writes:
Hello Marcus,
> On Mon, Jul 14, 2025 at 12:44:00PM +0200, Javier Martinez Canillas wrote:
>> It seems the driver took some inspiration from ssd130x and some of the
>> functions (encoder callbacks) were not renamed to use a st7571_ prefix.
>
> Outch, shame on me.
On the contrary, I'm glad to know that the ssd130x driver was useful :)
>>
>> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>
> Reviewed-by: Marcus Folkesson <marcus.folkesson@gmail.com>
>
Thanks for your review!
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2025-07-14 15:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-14 10:43 [PATCH v2 0/5] drm/sitronix/st7571-i2c: Add support for the ST7567 Controller Javier Martinez Canillas
2025-07-14 10:44 ` [PATCH v2 1/5] drm/sitronix/st7571-i2c: Fix encoder callbacks function names Javier Martinez Canillas
2025-07-14 12:06 ` Marcus Folkesson
2025-07-14 15:54 ` Javier Martinez Canillas [this message]
2025-07-14 10:44 ` [PATCH v2 2/5] drm/sitronix/st7571-i2c: Log probe deferral cause for GPIO get failure Javier Martinez Canillas
2025-07-14 12:04 ` Marcus Folkesson
2025-07-14 15:54 ` Javier Martinez Canillas
2025-07-14 10:44 ` [PATCH v2 3/5] drm/sitronix/st7571-i2c: Add an indirection level to parse DT Javier Martinez Canillas
2025-07-14 12:08 ` Marcus Folkesson
2025-07-14 10:44 ` [PATCH v2 4/5] dt-bindings: display: Add Sitronix ST7567 LCD Controller Javier Martinez Canillas
2025-07-14 10:44 ` [PATCH v2 5/5] drm/sitronix/st7571-i2c: Add support for the ST7567 Controller Javier Martinez Canillas
2025-07-14 12:11 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877c0a22g0.fsf@minerva.mail-host-address-is-not-set \
--to=javierm@redhat.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ipedrosa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=marcus.folkesson@gmail.com \
--cc=mripard@kernel.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).