From: Jani Nikula <jani.nikula@linux.intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 1/2] drm/dp: Fix read pointer for drm_dp_downsteam_debug()
Date: Fri, 21 Jul 2017 10:19:11 +0300 [thread overview]
Message-ID: <877ez2ntow.fsf@intel.com> (raw)
In-Reply-To: <20170720174532.23377-1-chris@chris-wilson.co.uk>
On Thu, 20 Jul 2017, Chris Wilson <chris@chris-wilson.co.uk> wrote:
> Pass in the array and not a pointer to the array to drm_dp_dpcd_read().
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_dp_helper.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_dp_helper.c b/drivers/gpu/drm/drm_dp_helper.c
> index 213fb837e1c4..1d9e30f0dbf8 100644
> --- a/drivers/gpu/drm/drm_dp_helper.c
> +++ b/drivers/gpu/drm/drm_dp_helper.c
> @@ -591,7 +591,7 @@ void drm_dp_downstream_debug(struct seq_file *m,
> seq_printf(m, "\t\tHW: %d.%d\n",
> (rev[0] & 0xf0) >> 4, rev[0] & 0xf);
>
> - len = drm_dp_dpcd_read(aux, DP_BRANCH_SW_REV, &rev, 2);
> + len = drm_dp_dpcd_read(aux, DP_BRANCH_SW_REV, rev, 2);
> if (len > 0)
> seq_printf(m, "\t\tSW: %d.%d\n", rev[0], rev[1]);
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-07-21 7:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-20 17:45 [PATCH 1/2] drm/dp: Fix read pointer for drm_dp_downsteam_debug() Chris Wilson
2017-07-20 17:45 ` [PATCH 2/2] drm/dp: Don't trust drm_dp_downstream_id() Chris Wilson
2017-07-21 7:22 ` Jani Nikula
2017-07-21 14:51 ` Jani Nikula
2017-07-21 15:01 ` Chris Wilson
2017-07-21 15:14 ` Jani Nikula
2017-07-21 7:19 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877ez2ntow.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox