From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2054C04FF9 for ; Wed, 17 Apr 2024 08:22:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3BC101132BE; Wed, 17 Apr 2024 08:22:05 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="cJnCgPOS"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.9]) by gabe.freedesktop.org (Postfix) with ESMTPS id 2804A1132BA; Wed, 17 Apr 2024 08:22:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1713342124; x=1744878124; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=ToIXFLsalA81kqrXe5Pngmqo3hSzK5CiSqKl/FIsk4s=; b=cJnCgPOSx8mG32IRRhYUqQaLw9thFc7AYGiiEr+g8wAAw+dkgVFOGlmw EK6zZXl/IW8wLD4gBji2Qe7jRfzmi2LGzOcAsfwD700p3P8yCBvpwhEqe Qtfqzb5EoaSdZrdauothCG0ZXuF04NvbB4Qq3TGlgwUr6r56SKsRoeC1g TpBE2PEDAP+4sbi5kkzrefydQDMZjwrjucN2YTHuIniynId+aanvIUZeK VtrOxra17Jx1Q0gpcVMf4MdGZcuNdCq75HQhLOuYVKPAN8NfUX+XI8Jmq IEU1jQdxWxclJWnt/ek0ke/t9KJDUPZ45gKr1fvoOlAU2d83PBjPHZw5w g==; X-CSE-ConnectionGUID: c9sQ3xHVR5G41QrHGL0zNA== X-CSE-MsgGUID: Wl1y3YC0QtOnp2pBMpWaCQ== X-IronPort-AV: E=McAfee;i="6600,9927,11046"; a="31303045" X-IronPort-AV: E=Sophos;i="6.07,208,1708416000"; d="scan'208";a="31303045" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 01:22:03 -0700 X-CSE-ConnectionGUID: 69GeIadEQBW73U1TI1YO6Q== X-CSE-MsgGUID: rmCNWOpPSTSf54qTXkhwxw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.07,208,1708416000"; d="scan'208";a="22418633" Received: from vpus-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.45.164]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Apr 2024 01:22:01 -0700 From: Jani Nikula To: Thomas Zimmermann , dri-devel@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Subject: Re: [REBASE 7/7] drm/edid: make drm_edid_are_equal() more convenient for its single user In-Reply-To: Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <1011a285d30babce3aabd8218abb7ece7dcf58a2.1713259151.git.jani.nikula@intel.com> <87h6g1ze42.fsf@intel.com> Date: Wed, 17 Apr 2024 11:21:58 +0300 Message-ID: <878r1cz9eh.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, 16 Apr 2024, Thomas Zimmermann wrote: > Hi > > Am 16.04.24 um 14:27 schrieb Jani Nikula: >> On Tue, 16 Apr 2024, Thomas Zimmermann wrote: >>> Hi >>> >>> Am 16.04.24 um 11:20 schrieb Jani Nikula: >>>> Repurpose drm_edid_are_equal() to be more helpful for its single user, >>>> and rename drm_edid_eq(). Functionally deduce the length from the blob >>>> size, not the blob data, making it more robust against any errors. >>> Could be squashed into patch 6. >> Ack. >> >> Thanks for the review. I'll hold of on resending these until there are >> some R-b's... I've send them a few times already with no comments. :( > > Feel free to add > > Reviewed-by: Thomas Zimmermann > > to the series. Many thanks! Just to double check, do you want me to move patch 5 earlier and squash patches 6&7? BR, Jani. -- Jani Nikula, Intel