From: Jani Nikula <jani.nikula@linux.intel.com>
To: intel-gfx@lists.freedesktop.org,
Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
Cc: Puthikorn Voravootivat <puthik@chromium.org>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v9 4/5] drm: Add definition for eDP backlight frequency
Date: Wed, 24 May 2017 11:40:22 +0300 [thread overview]
Message-ID: <878tlmodft.fsf@intel.com> (raw)
In-Reply-To: <20170523223805.46372-5-puthik@chromium.org>
On Tue, 23 May 2017, Puthikorn Voravootivat <puthik@chromium.org> wrote:
> This patch adds the following definition
> - Bit mask for EDP_PWMGEN_BIT_COUNT and min/max cap
> register which only use bit 0:4
> - Base frequency (27 MHz) for backlight PWM frequency
> generator.
>
> Signed-off-by: Puthikorn Voravootivat <puthik@chromium.org>
> Reviewed-by: Dhinakaran Pandiyan <dhinakaran.pandiyan@intel.com>
> ---
> include/drm/drm_dp_helper.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
> index c0bd0d7651a9..eaa307f6ae8c 100644
> --- a/include/drm/drm_dp_helper.h
> +++ b/include/drm/drm_dp_helper.h
> @@ -572,10 +572,12 @@
> #define DP_EDP_PWMGEN_BIT_COUNT 0x724
> #define DP_EDP_PWMGEN_BIT_COUNT_CAP_MIN 0x725
> #define DP_EDP_PWMGEN_BIT_COUNT_CAP_MAX 0x726
> +# define DP_EDP_PWMGEN_BIT_COUNT_MASK (0x1f << 0)
^^
Extra space crept in.
BR,
Jani.
>
> #define DP_EDP_BACKLIGHT_CONTROL_STATUS 0x727
>
> #define DP_EDP_BACKLIGHT_FREQ_SET 0x728
> +# define DP_EDP_BACKLIGHT_FREQ_BASE_KHZ 27000
>
> #define DP_EDP_BACKLIGHT_FREQ_CAP_MIN_MSB 0x72a
> #define DP_EDP_BACKLIGHT_FREQ_CAP_MIN_MID 0x72b
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-05-24 8:40 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-23 22:38 [PATCH v9 0/5] Enhancement to intel_dp_aux_backlight driver Puthikorn Voravootivat
2017-05-23 22:38 ` [PATCH v9 1/5] drm/i915: Drop AUX backlight enable check for backlight control Puthikorn Voravootivat
2017-05-24 8:16 ` Jani Nikula
2017-05-26 12:28 ` Jani Nikula
2017-05-23 22:38 ` [PATCH v9 2/5] drm/i915: Allow choosing how to adjust brightness if both supported Puthikorn Voravootivat
2017-05-24 8:26 ` [Intel-gfx] " Daniel Vetter
2017-05-23 22:38 ` [PATCH v9 3/5] drm/i915: Add option to support dynamic backlight via DPCD Puthikorn Voravootivat
2017-05-23 22:38 ` [PATCH v9 4/5] drm: Add definition for eDP backlight frequency Puthikorn Voravootivat
2017-05-24 8:40 ` Jani Nikula [this message]
2017-05-26 12:30 ` Jani Nikula
2017-05-23 22:38 ` [PATCH v9 5/5] drm/i915: Set PWM divider to match desired frequency in vbt Puthikorn Voravootivat
2017-05-26 12:49 ` Jani Nikula
2017-05-26 23:01 ` Puthikorn Voravootivat
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878tlmodft.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dhinakaran.pandiyan@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=puthik@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).