From: Jani Nikula <jani.nikula@intel.com>
To: David Lechner <david@lechnology.com>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 4/5] drm/dsi: rename MIPI_DCS_SET_PARTIAL_AREA to MIPI_DCS_SET_PARTIAL_ROWS
Date: Wed, 23 Oct 2019 10:32:21 +0300 [thread overview]
Message-ID: <87a79rgbne.fsf@intel.com> (raw)
In-Reply-To: <406d7ec4-f5b1-2ba4-a0ae-05fef4ab38b1@lechnology.com>
On Tue, 22 Oct 2019, David Lechner <david@lechnology.com> wrote:
> On 10/22/19 5:09 AM, Jani Nikula wrote:
>> The DCS command has been named SET_PARTIAL_ROWS in the DCS spec since
>> v1.02, for more than a decade. Rename the enumeration to match the spec.
>>
>> Cc: David Lechner <david@lechnology.com>
>> Cc: Vandita Kulkarni <vandita.kulkarni@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>
> I guess all of my documents are old and say set_partial_area, but I will
> take your word for it.
>
> It could be helpful to leave a comment in the code about the renaming
> so that if people with old docs search for SET_PARTIAL_AREA, they can
> still find it.
Something like this?
MIPI_DCS_SET_PARTIAL_ROWS = 0x30, /* aka MIPI_DCS_SET_PARTIAL_AREA */
It's also a possibility to define both:
MIPI_DCS_SET_PARTIAL_AREA = 0x30, /* _ROWS since MIPI DCS 1.02 */
MIPI_DCS_SET_PARTIAL_ROWS = 0x30,
I don't mind either way.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2019-10-23 7:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 10:09 [PATCH 0/5] drm/dsi: cleanups and compression helpers Jani Nikula
2019-10-22 10:09 ` [PATCH 1/5] drm/dsi: clean up DSI data type definitions Jani Nikula
2019-10-24 7:56 ` Kulkarni, Vandita
2019-10-24 7:56 ` Kulkarni, Vandita
2019-10-22 10:09 ` [PATCH 2/5] drm/dsi: add missing DSI data types Jani Nikula
2019-10-22 10:09 ` [PATCH 3/5] drm/dsi: add missing DSI DCS commands Jani Nikula
2019-10-22 10:09 ` [PATCH 4/5] drm/dsi: rename MIPI_DCS_SET_PARTIAL_AREA to MIPI_DCS_SET_PARTIAL_ROWS Jani Nikula
2019-10-22 14:31 ` David Lechner
2019-10-23 7:32 ` Jani Nikula [this message]
2019-10-22 10:09 ` [PATCH 5/5] drm/dsi: add helpers for DSI compression mode and PPS packets Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a79rgbne.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).