From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Keith Packard" <keithp@keithp.com>
Subject: Re: [PATCH] drm/dp: Do not prune the last mode on the connector
Date: Wed, 27 Sep 2017 17:31:56 -0700
Message-ID: <87a81fslxf.fsf@keithp.com>
References: <1506556833-2579-1-git-send-email-manasi.d.navare@intel.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0287500086=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <1506556833-2579-1-git-send-email-manasi.d.navare@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: intel-gfx@lists.freedesktop.org
Cc: Manasi Navare <manasi.d.navare@intel.com>, dri-devel@lists.freedesktop.org, Daniel Vetter <daniel.vetter@ffwll.ch>
List-Id: dri-devel@lists.freedesktop.org

--===============0287500086==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha256; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable

Manasi Navare <manasi.d.navare@intel.com> writes:

> This patch fixes this problem by checking if the mode being pruned
> is the last mode on that connector and if so doesnt prune it.

I think you want to stop pruning when you've gotten to a single mode on
the list, not at the last mode in the list (which may well need to be
pruned).

This is entirely untested, but perhaps

+		    !(list_is_singular(mode_list))) {
=20=20=20=20=20=20=20=20
is what you want?

=2D-=20
=2Dkeith

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEw4O3eCVWE9/bQJ2R2yIaaQAAABEFAlnMQvwACgkQ2yIaaQAA
ABGsFQ//d4QXMJC0NlcDMw7ybjtrwBbQYPDpK/DIjBbTBj181Qs+BNoEfLlQeSo6
zQVvvEMpWuK/m+h8N+YXlX9xymp/4cH2g4hb2PixMJB7xdKuV5uF9lsLlG4lvurl
ASeXRHZDw1vAXeNVidF9meUmkPOYeuhirRZALgBfeW+rJUzImhYRPTgEwszsIIAL
VZ9UAiKJzYoBdt4YI7DFu6Z7pWnLKkxEb3AUBr+KEa8ba7mr4EGSWpsxEgWRe7Fr
9NB2lRRUa6VgnQi2ytpn6J4A85cYVR89wenXKgCuebJpczD3YKLPnbDQxntdkYXq
hBSj7JdatlSsZh6MPy2Kdzz/pF4NUKZw98gMy57leNCo3yZl3FASlFOQA9g+u8Hd
DQXhxqHBMBuHaygl74W0icvwA4q6EPd7VvGezAzDPYMqv9UH4sWR390WkMOQJfhF
lQuCh32jYN1hqC2qqE0zxKlnARtcqvIzsR9SyFmMBCxJXeqbtk8iqXfyPWbY+xl/
VLPZdvLJ4Kd/1OSz38YRQqeLPEAsbhsmdPzI95AS3eW/bmNYOdG11UWCH3z2H1QA
FRwIXIjk69Kql/02BO79Lk6sYIQPcZNP1f4xB3mTqf9E8s9OC3sPGyL6D5z4CBfO
vZxMuhSvsgGU44HXXoMI1M9+c72vtsU7bKWbEaIvoVwkreXs/60=
=twZO
-----END PGP SIGNATURE-----
--=-=-=--

--===============0287500086==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==

--===============0287500086==--