From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] dri3, i915, i965: Add __DRI_IMAGE_FOURCC_SARGB8888 Date: Mon, 25 Nov 2013 14:08:00 -0800 Message-ID: <87a9gsceyn.fsf@eliezer.anholt.net> References: <1385093524-22276-1-git-send-email-keithp@keithp.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1278356414==" Return-path: In-Reply-To: <1385093524-22276-1-git-send-email-keithp@keithp.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: mesa-dev-bounces@lists.freedesktop.org Errors-To: mesa-dev-bounces@lists.freedesktop.org To: Keith Packard , mesa-dev@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1278356414== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Keith Packard writes: > The __DRIimage createImageFromFds function takes a fourcc code, but there was > no fourcc code that match __DRI_IMAGE_FORMAT_SARGB8. This adds a define for > that format, adds a translation in DRI3 from __DRI_IMAGE_FORMAT_SARGB8 to > __DRI_IMAGE_FOURCC_SARGB8888 and then adds translations *back* to > __IMAGE_FORMAT_SARGB8 in both the i915 and i965 drivers. > > I'll refrain from comments on whether I think having two separate sets of > format defines in dri_interface.h is a good idea or not... > > Signed-off-by: Keith Packard Reviewed-by: Eric Anholt I'd love to see some debug information in whatever path it was that was silently failing, if we can. It's so easy to miss places to add format support. (I see gallium doesn't use sargb images currently, but might want this in the future, plus we're still missing an equivalent change for 2101010 though I don't know if anybody's made it really work anywhere on dri2 either) --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.15 (GNU/Linux) iQIcBAEBCAAGBQJSk8pBAAoJELXWKTbR/J7ofDYP/3DrfUE6CeHA2tCz1IQsURs6 lvX+rT4SineWtppT8zd2YVqp2Ge8sy36oeqY5TEOuZ0XfPhsilQIZEBBb5PhmFgx b/V1I8rvw2BSe5u0PHP/GAWfVrT/PoipOkPRCZywMJmPt9oaetrLrrPfRBjmIx3d 4DyKpqgdHGF0zPLC/n2IgxxqFAcgOPmje3XJFTFnDHKs4aQo1N66vTU8gjcT0pgB OMWPwzn8SaGKy4bqUcFiLRvrFdsJn8QCzI1cIxV5tbl960MncN7sECamn1SDpoiL L8igWrmsw+MgiG/26EFY31rbyql6YOir0MFBqFz9Ym7Q/SbyzUJJw6UsiMUTJeja RyTtDBBeYEfNofCU9XtUFzMhATHd+jSMgFYVooA4mvqtmk0ZogwKfRziaHZYWnx8 SGP9Xs/dmPm8dB5XjZ3nZ9lcSip8Rnr5BYgiFsP5KRmINB2uBFcQvfmoE1LHNab1 epJGwWW4PEmEnUZcBdc7SsGCptGzI1oLBtO4i0/860LFVbjv99gbHdY79YnnwDXX CEhnlEJQOHpV4jngDlqwWFmKrkBsEVbvGRKg0Ek79shh7fWNtQ7wEkpy+SrwZE/3 7fFyRGgRnJCpZdmZGWBAvPIseBK2LizFSClbL+fyUOfvU06yX6Eo1myGXHTYSrKm m9y9nSFF+6rR6nMEqIci =rSLU -----END PGP SIGNATURE----- --=-=-=-- --===============1278356414== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev --===============1278356414==--