From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4582DC48BF6 for ; Mon, 4 Mar 2024 10:01:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9CACD10FF0A; Mon, 4 Mar 2024 10:01:52 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="hzzpqlFC"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5418510FF0B for ; Mon, 4 Mar 2024 10:01:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709546510; x=1741082510; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=jQFmwXYrCiO+fSgyXF1439DdxKJeLh5hmRnQ7FNWVbk=; b=hzzpqlFCr4scJTkwgDLk2EYT3To8biw2Jjw5l3VYqU33E0JAwPe+EX8l l3vwRnEK+xLBPMMFIOTg5GE/TNR5l8MO48c8DVtQ6xnJBo/9kDjRav0rE RJgOicmCpJTShM5Mh0KGt+0ha3lAzXsUiFPGRoRlFqH6LM88Ll0X669Yu IfmaHDg7KRKuq9v6TdH5IQDcmniGAg939cDt3dm9ey04BKt5yKDGDGrYI 91//xla0whTZt0qhHCag27H/+NJAwxwcyek5xDyYWufSNvHjefupid25C dMZRBSnTtvcGTvl8I2I+nG6qOl0X6pE3XSqCT57Gn5XZyckwkiPGb4sIc A==; X-IronPort-AV: E=McAfee;i="6600,9927,11002"; a="7799979" X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="7799979" Received: from fmviesa001.fm.intel.com ([10.60.135.141]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 02:01:45 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,203,1705392000"; d="scan'208";a="39935146" Received: from syakovle-mobl1.ger.corp.intel.com (HELO localhost) ([10.252.51.3]) by smtpauth.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Mar 2024 02:01:42 -0800 From: Jani Nikula To: Michael Ellerman , linuxppc-dev@lists.ozlabs.org Cc: dri-devel@lists.freedesktop.org, lkft-triage@lists.linaro.org, linux-kernel@vger.kernel.org, Naresh Kamboju , Thomas Zimmermann , Helge Deller , linux-fbdev@vger.kernel.org Subject: Re: [PATCH] powerpc: include linux/backlight.h from asm/backlight.h In-Reply-To: <20240304095512.742348-1-jani.nikula@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <20240304095512.742348-1-jani.nikula@intel.com> Date: Mon, 04 Mar 2024 12:01:30 +0200 Message-ID: <87bk7u5n9h.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, 04 Mar 2024, Jani Nikula wrote: > Removal of the backlight include from fb.h uncovered an implicit > dependency in powerpc asm/backlight.h. Add the explicit include. > > Reported-by: Naresh Kamboju > Closes: https://lore.kernel.org/r/CA+G9fYsAk5TbqqxFC2W4oHLGA0CbTHMxbeq8QayFXTU75YiueA@mail.gmail.com > Fixes: 11b4eedfc87d ("fbdev: Do not include in header") > Cc: Thomas Zimmermann > Cc: Helge Deller > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Jani Nikula > > --- > > Not even compile tested! Naresh, please try this patch! Michael, if this is fine by you, ack to merge via the drm subsystem along with the regressing commit? BR, Jani. > --- > arch/powerpc/include/asm/backlight.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/include/asm/backlight.h b/arch/powerpc/include/asm/backlight.h > index 1b5eab62ed04..275d5bb9aa04 100644 > --- a/arch/powerpc/include/asm/backlight.h > +++ b/arch/powerpc/include/asm/backlight.h > @@ -10,6 +10,7 @@ > #define __ASM_POWERPC_BACKLIGHT_H > #ifdef __KERNEL__ > > +#include > #include > #include -- Jani Nikula, Intel