From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH] drm/tve200: Clean up panel bridging Date: Fri, 08 Sep 2017 10:49:41 -0700 Message-ID: <87bmmlnkqy.fsf@anholt.net> References: <20170907211933.8308-1-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1762667129==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 610236EBD2 for ; Fri, 8 Sep 2017 17:49:57 +0000 (UTC) In-Reply-To: <20170907211933.8308-1-linus.walleij@linaro.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Linus Walleij , dri-devel@lists.freedesktop.org, Daniel Vetter , Jani Nikula , Sean Paul Cc: linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org --===============1762667129== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Linus Walleij writes: > This makes use of the drm_simple_display_pipe_attach_bridge() > call and removes the two calls removing the bridge, which were > erroneous: they unregister the bridge which is not what > we want, we just want to unreference it and that is already > handled by the core. > > Signed-off-by: Linus Walleij > --- > drivers/gpu/drm/tve200/tve200_display.c | 3 --- > drivers/gpu/drm/tve200/tve200_drv.c | 30 +++++++++++++--------------= --- > 2 files changed, 13 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/tve200/tve200_display.c b/drivers/gpu/drm/tv= e200/tve200_display.c > index cfdffc15a2ce..fd193377c3c0 100644 > --- a/drivers/gpu/drm/tve200/tve200_display.c > +++ b/drivers/gpu/drm/tve200/tve200_display.c > @@ -332,8 +332,5 @@ int tve200_display_init(struct drm_device *drm) > if (ret) > return ret; >=20=20 > - /* We need the encoder to attach the bridge */ > - priv->encoder =3D &priv->pipe.encoder; Also drop the encoder field from priv? Other than that, Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlmy2DUACgkQtdYpNtH8 nug4mw/+Jjgqv96OPWcjXDZzBQpnuHg+Qe4uIW7TFu21h36uF4D9y3Yka3CxtL/r TPxEn96xrGaV/Mpnyku81e0rG7R95nEIzEkejlBIPzlj5at36q79z/BKGVa2pLTU Fv4J7mgPn6SW6yYWjz961QF7jmDcvX68YRnbEBpKyW/PfkHcDerZbkTjK68TIWOr 0XRngnWzH1aK6dFSL9QLNIMJLo6th8kr0KO3Sl2N2A17JvbWARxGS7KAg9nlOwRH DC+T/szTsV0GE56DYiCsaZj5qVm4kYSWOj389axbM21isEhiqPal5VcI04LZNE14 mHO7vXHjtjnJ5dN0N08Aa6dFUDNErBTIw7vD1BH2IY8ayzRZxs725t9eZje4VPxw K7JWs5KUvp2YkaKfVI7xFIbnzMqTmy8N7Yh1aAtVvmX1t63pOd1JtS30NqhiVj3+ AwKQw3X7dC2F7IGnh0ItJHDcMEqKaaaDkrG4uiKGWTkPCpRzD59oz2Z7ZPQJaGyD vLSJ5fAreNpKlXVeesjDHmyRmENYtDoUtMG5wbHroj9jmhbSxoPQkqW2dnLa3QoT xrPqbrNSL6IT6iyfy5q7OsIbSBBUtgmLKE1xKNPxr7F8/9HFMtvODiU34b+RftiO Yy0yzHUeGFw5HK8+Al2UMxeb489k1um8yjILXoooMqOZiaj4QxY= =2JOc -----END PGP SIGNATURE----- --=-=-=-- --===============1762667129== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1762667129==--