From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 8/9] drm/vc4: Add support for async pageflips.
Date: Thu, 03 Dec 2015 17:42:41 -0800
Message-ID: <87d1ungfam.fsf@eliezer.anholt.net>
References: <1449002158-19156-1-git-send-email-eric@anholt.net>
 <1449002158-19156-8-git-send-email-eric@anholt.net>
 <CAPj87rN30D951JCi-JY9aONNmxFvo=gX2Sq1NohJg1jRs7AFhQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0445618362=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
In-Reply-To: <CAPj87rN30D951JCi-JY9aONNmxFvo=gX2Sq1NohJg1jRs7AFhQ@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Daniel Stone <daniel@fooishbar.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, dri-devel <dri-devel@lists.freedesktop.org>
List-Id: dri-devel@lists.freedesktop.org

--===============0445618362==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Daniel Stone <daniel@fooishbar.org> writes:

> Hi,
>
> On 1 December 2015 at 20:35, Eric Anholt <eric@anholt.net> wrote:
>> An async pageflip stores the modeset to be done and executes it once
>> the BOs are ready to be displayed.  This gets us about 3x performance
>> in full screen rendering with pageflipping.
>
> Looks good, but you're missing a preclose callback to reap dead events, a la:
> https://git.collabora.com/cgit/user/daniels/linux.git/commit/?h=wip/4.4.x/rockchip-drm-fixes&id=d14f21bcd7e7a1b9ca129c411a9da9c911037965
>
> (and parent commit to wire that through to core DRM preclose)

We've already got a preclose callback that reaps crtc->event -- see
vc4_cancel_page_flip().

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJWYO+SAAoJELXWKTbR/J7oSBUQALGEdEab+EW6u5SbPSLbYK/K
1UcRseWy5OYXoQccF9VDRqCHTrW9mqkrzupL9xzVDSBRdoakN0fe0sEy8gbu+Zoa
7qqKHpZrgm6odjOVbDUXi7RODjLCupkg5hlrPC3xk9MPIsTYwb+sNZp2wKTfIkFH
bWEh5MT3JXM+/wMva+l2rduBHdZPQGEnfDVPnhW7hnjhDCBuuZRAdaeC90TRdwkk
tzhRluvL7QCF6sb91XnmRJlAVekiodHHi1VyBz4k6jrDc9kACDfNxHIb9wtMbJ4i
j1LwBRx3mCLW2kCvU6Mduf2h0GYjEPExAn1H6M3wOLJZDRUDK9rdQqDocnaj7agt
GBWmkz9eFXOnLuvdczGJnbD+l4AMM9PW0nLcc9tTg7erOP1QMc9So2uK4adkUn+T
MWjUIAkODzYcLJPm1kTZZ/1yM4SHkRgt1soFmFKBbMt94l5osz5BXlt4uhxzDQe7
zLdCX5J/uf5v5uKOlKx9zNUrNtrmHo09oMmkjHBNtiPWEPb5o4jR4eEF3Urn5Wl7
f+zMZQF0gMAv8Yl2vMvw4u0MbQiwqFdm3wMRcCu9W0JZmZU7f8/MbIKuVrfTBuEa
oJWh2Q56FCkBkbwgMUydWhSUbG8ueeissZEpcipt4P1HNbjicMIftKwBj/yZxA90
HcQrfjs/ov08yGHXYW28
=s29n
-----END PGP SIGNATURE-----
--=-=-=--

--===============0445618362==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0
cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK

--===============0445618362==--