From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 1/2] drm/atomic: Add helpers for state-subclassing drivers Date: Fri, 27 Mar 2015 11:03:29 -0700 Message-ID: <87d23ugvwu.fsf@eliezer.anholt.net> References: <1427456044-7643-1-git-send-email-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1236549567==" Return-path: In-Reply-To: <1427456044-7643-1-git-send-email-thierry.reding@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding , dri-devel@lists.freedesktop.org Cc: Daniel Vetter List-Id: dri-devel@lists.freedesktop.org --===============1236549567== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Thierry Reding writes: > From: Thierry Reding > > Drivers that subclass CRTC, plane or connector state need to carefully > duplicate the code that the atomic helpers have. This is bound to cause > breakage eventually because it requires auditing all drivers and update > them when code is added to the helpers. > > In order to avoid that, implement new helpers that perform the required > steps when copying and destroying state. These new helpers are exported > so that state-subclassing drivers can use them. The default helpers are > implemented using them as well, providing a single location that needs > to be changed when adding to base atomic states. I was looking for these helpers when writing VC4 KMS. Thanks! Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBCgAGBQJVFZtxAAoJELXWKTbR/J7oy0sP/1fu3mQGtvEf5dG4zIK06Sk2 AOC8SrkRfARlnWZqFMxTkALlRkzWLN7ScVbePhjav3/y+j/Y0cn913Z3A3BW9dfl hSRtCQJXWHh4B8ZLLFs4tO8VzDCvb/7Ppw8n8EitTwBj6kTEn0ib0QUgOF/VZwSc TaP4o9AyAMJl74tAlBpQ414oDc2XWxua6WnULS0RZMe5PU2rd6wUNkc4nE2eLZST 5h1QoD9oGnrRiaT24ckG98qneRM8rw03m7BeJwGwIeapkfStxfuj+ptMB0C/GdTS qTwRWD0UPIx5tWYhxn4jsJtTT7eDSgD59TuXW0c8nk9HC4sQcL1KoXB80GpQhY5d Y+XJBl7DhGzvHDHlY/1D/HDc01h6NmpjURSOfUBfffh/bVVOpDCNOsglAzuyC82+ YiemC+kKqw4r4C6HEpIii53kjiXvfD7fkGYtx5qdZIUjvJD1shqjMlWhdMj92oGl id9d0+weE1dEeOS8w1k35nJjCFl/d6pVcs29gX8tBuRaY9NSErHbP9bKrP087WHm W1hvRLt8Dqyp8wFUwdqMzuPgg1YdNj/BVrsNU43HG6wp4zKPmDS/KuKyysvUiice tmoSz/M5ceJ4lX71NWB0JHt+0cJVwpoE3OcNWUrZFH8M2UFWLA67KDFHrX5JyhO8 BQm/tfG7nozf/dEkdKGg =ZX0Z -----END PGP SIGNATURE----- --=-=-=-- --===============1236549567== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK --===============1236549567==--