Re: [PATCH] drm/edid: Remove defunct EDID_QUIRK_FIRST_DETAILED_PREFERRED

From: Jani Nikula <jani.nikula@linux.intel.com>
To: Ville Syrjala <ville.syrjala@linux.intel.com>,
	dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH] drm/edid: Remove defunct EDID_QUIRK_FIRST_DETAILED_PREFERRED
Date: Fri, 22 Mar 2019 20:23:41 +0200	[thread overview]
Message-ID: <87ef6ybweq.fsf@intel.com> (raw)
In-Reply-To: <20190322174244.23945-1-ville.syrjala@linux.intel.com>

On Fri, 22 Mar 2019, Ville Syrjala <ville.syrjala@linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Looks like EDID_QUIRK_FIRST_DETAILED_PREFERRED never did anything.
> Its counterpart in f86EdidModes.c is properly hooked up but somehow
> that functionality was lost when it was copied into the kernel.
>
> The concensus seems to be that this quirk is a bit misguided
> anyway so let's nuke the leftovers.
>
> For posterity here are some links to known cases:
> * Proview AY765C
>   https://bugs.freedesktop.org/show_bug.cgi?id=15160
> * Unknown Acer
>   https://bugzilla.redhat.com/show_bug.cgi?id=284231 (got the
>   reference from xf86EdidModes.c)
> * Peacock Ergovision 19 (only in xf86EdidModes.c)
>   https://bugzilla.redhat.com/show_bug.cgi?id=492359
> * Philips 107p5 CRT
>   "Reported on xorg@ with pastebin", didn't find the mail(s)
>
> Cc: Adam Jackson <ajax@redhat.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>

Reviewed-by: Jani Nikula <jani.nikula@intel.com>


> ---
>  drivers/gpu/drm/drm_edid.c | 10 ----------
>  1 file changed, 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
> index fa39592ebc0a..2c22ea446075 100644
> --- a/drivers/gpu/drm/drm_edid.c
> +++ b/drivers/gpu/drm/drm_edid.c
> @@ -68,8 +68,6 @@
>   * maximum size and use that.
>   */
>  #define EDID_QUIRK_DETAILED_USE_MAXIMUM_SIZE	(1 << 4)
> -/* Monitor forgot to set the first detailed is preferred bit. */
> -#define EDID_QUIRK_FIRST_DETAILED_PREFERRED	(1 << 5)
>  /* use +hsync +vsync for detailed mode */
>  #define EDID_QUIRK_DETAILED_SYNC_PP		(1 << 6)
>  /* Force reduced-blanking timings for detailed modes */
> @@ -107,8 +105,6 @@ static const struct edid_quirk {
>  	{ "ACR", 44358, EDID_QUIRK_PREFER_LARGE_60 },
>  	/* Acer F51 */
>  	{ "API", 0x7602, EDID_QUIRK_PREFER_LARGE_60 },
> -	/* Unknown Acer */
> -	{ "ACR", 2423, EDID_QUIRK_FIRST_DETAILED_PREFERRED },
>  
>  	/* AEO model 0 reports 8 bpc, but is a 6 bpc panel */
>  	{ "AEO", 0, EDID_QUIRK_FORCE_6BPC },
> @@ -145,12 +141,6 @@ static const struct edid_quirk {
>  	{ "LPL", 0, EDID_QUIRK_DETAILED_USE_MAXIMUM_SIZE },
>  	{ "LPL", 0x2a00, EDID_QUIRK_DETAILED_USE_MAXIMUM_SIZE },
>  
> -	/* Philips 107p5 CRT */
> -	{ "PHL", 57364, EDID_QUIRK_FIRST_DETAILED_PREFERRED },
> -
> -	/* Proview AY765C */
> -	{ "PTS", 765, EDID_QUIRK_FIRST_DETAILED_PREFERRED },
> -
>  	/* Samsung SyncMaster 205BW.  Note: irony */
>  	{ "SAM", 541, EDID_QUIRK_DETAILED_SYNC_PP },
>  	/* Samsung SyncMaster 22[5-6]BW */

-- 
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx