dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Jörg Otte" <jrg.otte@gmail.com>
Cc: Aaron Lu <aaron.lu@intel.com>,
	Igor Gnatenko <i.gnatenko.brain@gmail.com>,
	ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
	intel-gfx <intel-gfx@lists.freedesktop.org>,
	dri-devel@lists.freedesktop.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Daniel Vetter <daniel@ffwll.ch>,
	"Rafael J. Wysocki" <rjw@sisk.pl>,
	Matthew Garrett <matthew.garrett@nebula.com>,
	Seth Forshee <seth.forshee@canonical.com>,
	Lee Chun-Yi <joeyli.kernel@gmail.com>,
	Richard Purdie <rpurdie@rpsys.net>,
	Yves-Alexis Perez <corsac@debian.org>,
	Felipe Contreras <felipe.contreras@gmail.com>,
	Henrique de Moraes Holschuh <ibm-acpi@hmh.eng.br>,
	Ben Jencks <ben@bjencks.net>,
	Steven Newbury <steve@snewbury.org.uk>,
	James Hogan <james@albanarts.com>,
	Kamal Mostafa <kamal@canonical.com>,
	Joerg Platte <jplatte@naasa.net>, Kalle Valo <kvalo@adurom.com>,
	Martin Steigerwald <Martin@lichtvol>
Subject: Re: [PATCH v3 0/4] Fix Win8 backlight issue
Date: Wed, 25 Sep 2013 19:17:04 +0300	[thread overview]
Message-ID: <87eh8clvun.fsf@intel.com> (raw)
In-Reply-To: <CADDKRnDqDBfA6e6TE0VTLD9F=TjVZNov53Zk8ydnk2fS32rczQ@mail.gmail.com>

On Wed, 25 Sep 2013, Jörg Otte <jrg.otte@gmail.com> wrote:
> 2013/9/25 Jani Nikula <jani.nikula@linux.intel.com>:
>> On Wed, 25 Sep 2013, Aaron Lu <aaron.lu@intel.com> wrote:
>>> On Wed, Sep 25, 2013 at 10:29:37AM +0200, Jörg Otte wrote:
>>>> Backlight can't be modified with this patch set - neither with
>>>> function keys nor with the gui. It is a step backward to v3.11-rc1
>>
>> So both hotkeys and GUI work in v3.11-rc1? And v3.12-rc2?
>
> In  v3.11-rc1 it didn't work.
> Since a later rc (I don't remember exactly which) it did work.
> In v3.12-rc1/2 it does work.
> In v3.12-rc2 + Aaron's patch set it again doesn't work.
>
>>
>>> Thanks for the test.
>>>
>>> Please check /sys/class/backlight, is there only one link file
>>> intel_backlight?
>>
>> Indeed, are there others? fujitsu-laptop perhaps? If yes, try
>> CONFIG_FUJITSU_LAPTOP=n or an appropriate module blacklist.
>>
>> Just checking, you do have CONFIG_BACKLIGHT_CLASS_DEVICE=y?
>
> There is only one intel_backlight link.
> Yes, I have CONFIG_BACKLIGHT_CLASS_DEVICE=y
>
>> Embarrassingly there was a bug in i915 fixed just recently where the
>> backlight device wasn't registered for
>> CONFIG_BACKLIGHT_CLASS_DEVICE=m...
>>
>>> If so, please cd inside and try modify the brightness file using echo
>>> with some values in the range of 0 - max_brightness, does the
>>> backlight level change when you echo a new value? I guess it doesn't,
>>> or you wouldn't notice problem. If indeed so, perhaps file a bug at
>>> http://bugzilla.kernel.org, Drivers/Video(DRI-Intel)? I suppose Jani
>>> and Daniel can help fix your problem.
>>
>> Yup, please check the above, and report back.
>
> - echo 0..max_brightness > brightness does not work.

Thanks for the info.

How about v3.12-rc2 without Aaron's patches? Does intel_backlight also
not work there? How about the acpi_video0 (which I presume is present)
sysfs interface?

BR,
Jani.



>
>>>>
>>>> Video driver: i915
>>>> FUJITSU LIFEBOOK AH532/FJNBB1C, BIOS Version 1.09 05/22/2012
>>>>
>>>> acpi_backlight=video works.
>
> Jörg

  reply	other threads:[~2013-09-25 16:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-24  9:47 [PATCH v3 0/4] Fix Win8 backlight issue Aaron Lu
2013-09-24  9:47 ` [PATCH v3 1/4] backlight: introduce backlight_device_registered Aaron Lu
2013-09-24  9:47 ` [PATCH v3 2/4] ACPI / video: seperate backlight control and event interface Aaron Lu
2013-09-24  9:54   ` Aaron Lu
2013-10-07 12:09     ` Rafael J. Wysocki
2013-09-24  9:47 ` [PATCH v3 3/4] ACPI / video: Do not register backlight if win8 and native interface exists Aaron Lu
2013-09-25 17:53   ` Rafael J. Wysocki
2013-09-26  5:15     ` Aaron Lu
2013-09-24  9:47 ` [PATCH v3 4/4] thinkpad-acpi: fix handle locate for video and query of _BCL Aaron Lu
2013-09-25 19:58   ` Henrique de Moraes Holschuh
2013-09-26  1:44     ` Aaron Lu
2013-09-27 15:16       ` Henrique de Moraes Holschuh
2013-09-27 15:20   ` Henrique de Moraes Holschuh
2013-09-27 15:33     ` Yves-Alexis Perez
2013-09-27 18:05       ` Henrique de Moraes Holschuh
2013-09-28 12:28         ` Yves-Alexis Perez
2013-09-24 12:42 ` [PATCH v3 0/4] Fix Win8 backlight issue Igor Gnatenko
2013-09-25  8:29   ` Jörg Otte
2013-09-25  9:17     ` Aaron Lu
2013-09-25 10:41       ` Jani Nikula
2013-09-25 15:51         ` Jörg Otte
2013-09-25 16:17           ` Jani Nikula [this message]
2013-09-26  7:49             ` Jörg Otte
2013-09-27  0:26               ` Rafael J. Wysocki
2013-09-28 16:34                 ` Jörg Otte
2013-09-27 11:02 ` Mika Westerberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87eh8clvun.fsf@intel.com \
    --to=jani.nikula@linux.intel.com \
    --cc=Martin@lichtvol \
    --cc=aaron.lu@intel.com \
    --cc=ben@bjencks.net \
    --cc=corsac@debian.org \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=felipe.contreras@gmail.com \
    --cc=i.gnatenko.brain@gmail.com \
    --cc=ibm-acpi@hmh.eng.br \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=james@albanarts.com \
    --cc=joeyli.kernel@gmail.com \
    --cc=jplatte@naasa.net \
    --cc=jrg.otte@gmail.com \
    --cc=kamal@canonical.com \
    --cc=kvalo@adurom.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.garrett@nebula.com \
    --cc=rjw@sisk.pl \
    --cc=rpurdie@rpsys.net \
    --cc=seth.forshee@canonical.com \
    --cc=steve@snewbury.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).