dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org,
	Andrzej Hajda <andrzej.hajda@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Robert Foss <rfoss@kernel.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>,
	Jernej Skrabec <jernej.skrabec@gmail.com>
Subject: Re: [PATCH 0/2] drm/bridge: start moving towards struct drm_edid
Date: Tue, 19 Dec 2023 14:15:36 +0200	[thread overview]
Message-ID: <87frzytml3.fsf@intel.com> (raw)
In-Reply-To: <87jzqksg8g.fsf@intel.com>

On Tue, 14 Nov 2023, Jani Nikula <jani.nikula@intel.com> wrote:
> On Thu, 26 Oct 2023, Jani Nikula <jani.nikula@intel.com> wrote:
>> This is just the first two patches of a lengthy series that I'm not
>> really sure how to proceed with. Basically the series converts all of
>> drm/bridge to the new struct drm_edid infrastructure. It's safer than
>> struct edid, because it contains meta information about the allocated
>> size of the EDID, instead of relying on the size (number of extensions)
>> originating from outside of the kernel.
>>
>> The rest is at [1]. The commit messages are lacking, and I don't really
>> have the toolchain to even build test most of it. But I think this is
>> where drm/bridge should go. Among all of drm, I think bridge has the
>> most uses of struct edid that do not originate from the drm_get_edid()
>> family of functions, which means the validity checks are somewhat
>> inconsistent, and having the meta information is more crucial.
>>
>> Bridge maintainers, please instruct how to best proceed with this.
>
> Ping.

Ping.

>
> The two patches posted here could be merged, to add something to build
> the later commits on gradually.
>
> BR,
> Jani.
>
>>
>>
>> Thanks,
>> Jani.
>>
>>
>>
>> [1] https://gitlab.freedesktop.org/jani/linux/-/commits/drm-edid-bridge
>>
>>
>>
>> Jani Nikula (2):
>>   drm/bridge: add ->edid_read hook and drm_bridge_edid_read()
>>   drm/bridge: switch to drm_bridge_read_edid()
>>
>>  drivers/gpu/drm/drm_bridge.c           | 46 +++++++++++++++++++++++++-
>>  drivers/gpu/drm/drm_bridge_connector.c | 16 ++++-----
>>  include/drm/drm_bridge.h               | 33 ++++++++++++++++++
>>  3 files changed, 86 insertions(+), 9 deletions(-)

-- 
Jani Nikula, Intel

  reply	other threads:[~2023-12-19 12:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-26  9:39 [PATCH 0/2] drm/bridge: start moving towards struct drm_edid Jani Nikula
2023-10-26  9:39 ` [PATCH 1/2] drm/bridge: add ->edid_read hook and drm_bridge_edid_read() Jani Nikula
2023-12-22 19:27   ` Dmitry Baryshkov
2023-12-27 11:45     ` Jani Nikula
2023-10-26  9:39 ` [PATCH 2/2] drm/bridge: switch to drm_bridge_read_edid() Jani Nikula
2023-11-14 11:53 ` [PATCH 0/2] drm/bridge: start moving towards struct drm_edid Jani Nikula
2023-12-19 12:15   ` Jani Nikula [this message]
2023-12-22  8:09     ` Neil Armstrong
2023-12-22  9:24       ` Jani Nikula
2023-12-22 15:53         ` Jani Nikula
2024-01-03 10:13           ` Jani Nikula

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87frzytml3.fsf@intel.com \
    --to=jani.nikula@intel.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=andrzej.hajda@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=jonas@kwiboo.se \
    --cc=neil.armstrong@linaro.org \
    --cc=rfoss@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).