Re: [PATCH] drm: change logs to print connectors in the form CONNECTOR:id:name

[Jani Nikula <jani.nikula@linux.intel.com>]

On Sun, 14 Nov 2021, Claudio Suarez <cssk@net-c.es> wrote:
> On Sat, Nov 13, 2021 at 09:39:46PM +0100, Sam Ravnborg wrote:
>> Hi Claudio,
>> 
>> On Sat, Nov 13, 2021 at 08:27:30PM +0100, Claudio Suarez wrote:
>> > The prefered way to log connectors is [CONNECTOR:id:name]. Change it in
>> > drm core programs.
>> > 
>> > Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> > Signed-off-by: Claudio Suarez <cssk@net-c.es>
>> 
>> While touching all these logging calls, could you convernt them to the
>> newer drm_dbg_kms variants?
>> DRM_DEBUG_* are all deprecated.
>> 
>
> Yes, I can, but it is recommended to do it in a different patch:
>
> https://www.kernel.org/doc/html/latest/process/submitting-patches.html#separate-your-changes
>
> C&P:
> "Separate your changes
> Separate each logical change into a separate patch.
> For example, if your changes include both bug fixes and performance enhancements..."
>
>
> I will study and send a new separate patch with your suggestion.

I feel these logging changes are the types of changes where I'd err on
the side of fewer patches than strictly following the above guidelines.

BR,
Jani.


>
> Best regards,
> Claudio Suarez
>
>
>

-- 
Jani Nikula, Intel Open Source Graphics Center