From: Jani Nikula via dri-devel <dri-devel@lists.freedesktop.org>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"David Santamaría Rogado" <howl.nsp@gmail.com>
Cc: David Airlie <airlied@linux.ie>, dri-devel@lists.freedesktop.org
Subject: Re: Fwd: [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting
Date: Thu, 14 Feb 2019 12:55:57 +0200 [thread overview]
Message-ID: <87ftsqwsea.fsf@intel.com> (raw)
In-Reply-To: <20190213124126.GG647@ulmo>
On Wed, 13 Feb 2019, Thierry Reding <thierry.reding@gmail.com> wrote:
> On Wed, Feb 13, 2019 at 11:13:23AM +0100, David Santamaría Rogado wrote:
>> Sorry previous one wasn't signed off by.
>
> And now you've got this comment in the commit message that's going to
> confuse people looking at the log.
>
> It's usually to put this kind of comment below the --- line...
>
>> The (void *) casting in the driver_data variable assignment is superfluous.
>> Spotted by Jani Nikula.
Please either make that
Suggested-by: Jani Nikula <jani.nikula@intel.com>
or leave out completely.
>>
>> Signed-off-by: David Santamaría Rogado <howl.nsp at gmail.com>
>> ---
>
> ... right here.
>
>> drivers/gpu/drm/drm_panel_orientation_quirks.c | 18 +++++++++---------
>> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> Otherwise, looks good to me:
>
> Acked-by: Thierry Reding <treding@nvidia.com>
With Thierry's suggestion fixed,
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-02-14 10:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-13 10:03 [PATCH] drm: panel-orientation-quirks: Get rid of superfluous (void *) casting David Santamaría Rogado via dri-devel
2019-02-13 10:13 ` Fwd: " David Santamaría Rogado via dri-devel
2019-02-13 12:41 ` Thierry Reding via dri-devel
2019-02-14 10:55 ` Jani Nikula via dri-devel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ftsqwsea.fsf@intel.com \
--to=dri-devel@lists.freedesktop.org \
--cc=airlied@linux.ie \
--cc=howl.nsp@gmail.com \
--cc=jani.nikula@linux.intel.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox