From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v4 1/2] drm/vc4: Add CTM support Date: Mon, 23 Apr 2018 11:54:49 -0700 Message-ID: <87fu3l4uti.fsf@anholt.net> References: <20180420122545.40014-1-stschake@gmail.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1531124719==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 182836E2E3 for ; Mon, 23 Apr 2018 18:54:52 +0000 (UTC) In-Reply-To: <20180420122545.40014-1-stschake@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stefan Schake List-Id: dri-devel@lists.freedesktop.org --===============1531124719== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Stefan Schake writes: > The hardware has a single block for applying a CTM prior to gamma lut. > It can be fed with pixels from one of our CRTC at a time and uses a > matrix with S0.9 scalars. Use private atomic state to reject attempts > from userland to apply CTM for more than one CRTC at a time and reject > matrices with scalars that we can't approximate without integer bits. Looks good! I think you got all the transition cases we were concerned about before. Reviewed and applied these two to drm-misc-next. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIyBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlreK/kACgkQtdYpNtH8 nuivrg/3QWOHIW2f3/aubiNWNFtlU7tMi41uWUWsnTpgYPd/zuiW3Waf+atMl9XX /VsiQqmJrUQAFtb2O1KAQ+CTPvi/Up9zuPDOfRc9eX1ORD/XIXoD7DfcoesfysV4 U4Oad6BjSIrxWAfkSz9h5bSo9aGktxbiQr4t2n8j349xmfrfpxLH5JtgDyuaQkZ3 KEwzjHthpnVlKrppFoLVfZtdvtX33WLj2GqAzQ21P2BewLBMWhElcqvbmZ4CW532 aGeQ/zIPzfxwl5udRJbp4yiIQ8xSv5V2kHqfZbTJUmG132Z3abPlbAGJxmF6XXOx nemnYmGP967c1yw7BUcTTUoWlWOvpdj38ZBxMAnuK5J0rtKwy0K+wTh+3dOexsGG g/HTZWEVY8Bl/AW53ZyY2Pylls7q+HCM7cP9aBJq9uqJMUU9GsQF6PryimsAVIgt dB/2lXKSL0QE4wVzTpR8L1359933ZgC1lCaLXKTmcFkevwmMzWf3pkaxeG+GPvEv imC2IUz1ayczTZm6pogr/ER/wKxqZm96JSGcKw7rnCIBTBU/7ijTUkTE4mke3Gqw HwPaculiksZLBMtQUxgDaMy7UcOQXvicw+THUpM5XaQwNbfGFYlBpDFdc1fBIpI9 0bctdpejB68pV2v8mKEDSGTrG7xPNqXbTeNAP5t0CrRGuQ6+pA== =4WJI -----END PGP SIGNATURE----- --=-=-=-- --===============1531124719== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1531124719==--