From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v3 02/23] drm: remove drm_vblank_no_hw_counter assignment from driver code Date: Wed, 08 Feb 2017 11:58:18 -0800 Message-ID: <87fujoe9ph.fsf@eliezer.anholt.net> References: <1486458995-31018-1-git-send-email-shawnguo@kernel.org> <1486458995-31018-3-git-send-email-shawnguo@kernel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1406002662==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id C2DFC6E9A1 for ; Wed, 8 Feb 2017 19:58:20 +0000 (UTC) In-Reply-To: <1486458995-31018-3-git-send-email-shawnguo@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shawn Guo , Daniel Vetter Cc: Neil Armstrong , Liviu Dudau , Laurent Pinchart , Daniel Vetter , Marek Vasut , Alexey Brodkin , Russell King , Xinliang Liu , Tomi Valkeinen , Mali DP Maintainers , Ben Skeggs , Jyri Sarha , dri-devel@lists.freedesktop.org, Maxime Ripard List-Id: dri-devel@lists.freedesktop.org --===============1406002662== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Shawn Guo writes: > From: Shawn Guo > > Core code already makes drm_driver.get_vblank_counter hook optional by > letting drm_vblank_no_hw_counter be the default implementation for the > function hook. So the drm_vblank_no_hw_counter assignment in the driver > code becomes redundant and can be removed now. Thanks. Missing this hook was actually a problem in vc4 for a while, so it's nice to have sensible defaults. For vc4: Acked-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlibeFoACgkQtdYpNtH8 nuiGbg//Se/rWGUlpYmwj4KSnJBKPNC3s4KFRl9u45wwiMFfPmzScwxbjZ8Usyx8 gv25wQG9W5uA6PQMDrKAFxUb+5cl6u4OnYHRdwiWgvZXKoFXPHU7YVxwjgaN+7CN QFOAqVGF6KwQIoxKWoWzLxxe6dAv0NidsGQvPFauVWl4NdwXc3YqMe22KdaxQof2 r8HyinQqWXeYwFttt56/VrC2MBFjiIB2ivRaCT1PR1XS4A4YO/OGyY3T4Hw7YqPf FboXXni3LTCXz7FTovKccA+OKcifAosLKFvl/J/Nmp8wkSOZdiUrjdLWV3Wh/Sbb mzaDHtfa1bT3B84Dj7Z3qOVj/GLwNu+3k3iv3u1egRTmOw6cyfi6Fz2K/6HI4fHk yK+sUYBnAEiB+PohUYcwzbylXr9M3Ea5vHeSKjeKbOM9j5RUWsl4Qv1SfXEhTfIb xdiGVdJtZSuyOkN73UJTogaAFMr91HRT3D9Bji4eyxzU/KYXyuusdU8vIwVbWYOG ASXPRipH1RVclZTft7D+OYV5FpJ8NeRlOuXB5xc3RKmL+SNsd9EM56+yWn+W4VO0 LuCvcqcXmqS7HG2ScgVwdmrfszHtX+c4NbxZlfAxg8VJ0uYcc6gyxTg4xFxRh4xZ Fq5hHl7ONUPyLJrAxNG6MvQ7TsNLU/JiTcLS5eeurglLcmNMpWU= =5gq9 -----END PGP SIGNATURE----- --=-=-=-- --===============1406002662== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1406002662==--