From mboxrd@z Thu Jan 1 00:00:00 1970 From: Robert Jarzmik Subject: Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table Date: Wed, 30 Oct 2019 22:10:48 +0100 Message-ID: <87h83qlz1j.fsf@belgarion.home> References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-38-arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20191018154201.1276638-38-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:53 +0200") List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Arnd Bergmann Cc: Daniel Thompson , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Jingoo Han , Linus Walleij , linux-kernel@vger.kernel.org, Haojian Zhuang , Daniel Mack , linux-fbdev@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org List-Id: dri-devel@lists.freedesktop.org Arnd Bergmann writes: > The driver should not require a machine specific header. Change > it to pass the gpio line through a lookup table, and move the > timing generator definitions into the drivers itself. > > Cc: Lee Jones > Cc: Daniel Thompson > Cc: Jingoo Han > Cc: Bartlomiej Zolnierkiewicz > Cc: dri-devel@lists.freedesktop.org > Cc: linux-fbdev@vger.kernel.org > Signed-off-by: Arnd Bergmann > > --- > I'm not overly confident that I got the correct device names > for the lookup table, it would be good if someone could > double-check. Ah the I2C and SPI devices querrying GPIOs ... unless someone does an actual test, this will probably be very regression prone ... Anyway : Acked-by: Robert Jarzmik Cheers. -- Robert From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFDE6CA9ECB for ; Thu, 31 Oct 2019 09:05:38 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9EFD92083E for ; Thu, 31 Oct 2019 09:05:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9EFD92083E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=free.fr Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5AE636EDF4; Thu, 31 Oct 2019 09:04:55 +0000 (UTC) Received: from smtp.smtpout.orange.fr (smtp08.smtpout.orange.fr [80.12.242.130]) by gabe.freedesktop.org (Postfix) with ESMTPS id 281156EB90 for ; Wed, 30 Oct 2019 21:10:54 +0000 (UTC) Received: from belgarion ([90.55.204.252]) by mwinf5d15 with ME id KxAo210045TFNlm03xAoN2; Wed, 30 Oct 2019 22:10:52 +0100 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Wed, 30 Oct 2019 22:10:52 +0100 X-ME-IP: 90.55.204.252 From: Robert Jarzmik To: Arnd Bergmann Subject: Re: [PATCH 38/46] video: backlight: tosa: use gpio lookup table References: <20191018154052.1276506-1-arnd@arndb.de> <20191018154201.1276638-38-arnd@arndb.de> X-URL: http://belgarath.falguerolles.org/ Date: Wed, 30 Oct 2019 22:10:48 +0100 In-Reply-To: <20191018154201.1276638-38-arnd@arndb.de> (Arnd Bergmann's message of "Fri, 18 Oct 2019 17:41:53 +0200") Message-ID: <87h83qlz1j.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/26 (gnu/linux) MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 31 Oct 2019 09:04:21 +0000 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , dri-devel@lists.freedesktop.org, Bartlomiej Zolnierkiewicz , Jingoo Han , linux-kernel@vger.kernel.org, Haojian Zhuang , Daniel Mack , linux-fbdev@vger.kernel.org, Lee Jones , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191030211048.brl47UMkUy-KjoSehjUVN_xZkpxc4LLEj18Xj9yWr44@z> QXJuZCBCZXJnbWFubiA8YXJuZEBhcm5kYi5kZT4gd3JpdGVzOgoKPiBUaGUgZHJpdmVyIHNob3Vs ZCBub3QgcmVxdWlyZSBhIG1hY2hpbmUgc3BlY2lmaWMgaGVhZGVyLiBDaGFuZ2UKPiBpdCB0byBw YXNzIHRoZSBncGlvIGxpbmUgdGhyb3VnaCBhIGxvb2t1cCB0YWJsZSwgYW5kIG1vdmUgdGhlCj4g dGltaW5nIGdlbmVyYXRvciBkZWZpbml0aW9ucyBpbnRvIHRoZSBkcml2ZXJzIGl0c2VsZi4KPgo+ IENjOiBMZWUgSm9uZXMgPGxlZS5qb25lc0BsaW5hcm8ub3JnPgo+IENjOiBEYW5pZWwgVGhvbXBz b24gPGRhbmllbC50aG9tcHNvbkBsaW5hcm8ub3JnPgo+IENjOiBKaW5nb28gSGFuIDxqaW5nb29o YW4xQGdtYWlsLmNvbT4KPiBDYzogQmFydGxvbWllaiBab2xuaWVya2lld2ljeiA8Yi56b2xuaWVy a2llQHNhbXN1bmcuY29tPgo+IENjOiBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4g Q2M6IGxpbnV4LWZiZGV2QHZnZXIua2VybmVsLm9yZwo+IFNpZ25lZC1vZmYtYnk6IEFybmQgQmVy Z21hbm4gPGFybmRAYXJuZGIuZGU+Cj4KPiAtLS0KPiBJJ20gbm90IG92ZXJseSBjb25maWRlbnQg dGhhdCBJIGdvdCB0aGUgY29ycmVjdCBkZXZpY2UgbmFtZXMKPiBmb3IgdGhlIGxvb2t1cCB0YWJs ZSwgaXQgd291bGQgYmUgZ29vZCBpZiBzb21lb25lIGNvdWxkCj4gZG91YmxlLWNoZWNrLgpBaCB0 aGUgSTJDIGFuZCBTUEkgZGV2aWNlcyBxdWVycnlpbmcgR1BJT3MgLi4uIHVubGVzcyBzb21lb25l IGRvZXMgYW4gYWN0dWFsCnRlc3QsIHRoaXMgd2lsbCBwcm9iYWJseSBiZSB2ZXJ5IHJlZ3Jlc3Np b24gcHJvbmUgLi4uCgpBbnl3YXkgOgpBY2tlZC1ieTogUm9iZXJ0IEphcnptaWsgPHJvYmVydC5q YXJ6bWlrQGZyZWUuZnI+CgpDaGVlcnMuCgotLQpSb2JlcnQKX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2 ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21h aWxtYW4vbGlzdGluZm8vZHJpLWRldmVs