From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH v5 12/19] drm: writeback: Cleanup job ownership handling
 when queuing job
Date: Thu, 21 Feb 2019 08:40:41 -0800
Message-ID: <87h8cxm6wm.fsf@anholt.net>
References: <20190221103212.28764-1-laurent.pinchart+renesas@ideasonboard.com>
 <20190221103212.28764-13-laurent.pinchart+renesas@ideasonboard.com>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============0342389993=="
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from anholt.net (anholt.net [50.246.234.109])
 by gabe.freedesktop.org (Postfix) with ESMTP id 9CEB7897D0
 for <dri-devel@lists.freedesktop.org>; Thu, 21 Feb 2019 16:40:58 +0000 (UTC)
In-Reply-To: <20190221103212.28764-13-laurent.pinchart+renesas@ideasonboard.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, dri-devel@lists.freedesktop.org
Cc: James Qian Wang <james.qian.wang@arm.com>, Liviu Dudau <Liviu.Dudau@arm.com>, Kieran Bingham <kieran.bingham@ideasonboard.com>
List-Id: dri-devel@lists.freedesktop.org

--===============0342389993==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain

Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> writes:

> The drm_writeback_queue_job() function takes ownership of the passed job
> and requires the caller to manually set the connector state
> writeback_job pointer to NULL. To simplify drivers and avoid errors
> (such as the missing NULL set in the vc4 driver), pass the connector
> state pointer to the function instead of the job pointer, and set the
> writeback_job pointer to NULL internally.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>

Acked-by: Eric Anholt <eric@anholt.net>

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlxu1JgACgkQtdYpNtH8
nuh5mQ/7BxCnCf8b0PNt0jT/Wg8UNujlUCLF3R+QMMqwgGfAKNJ/uro/5K3py95z
XRpOD/rJOzyr5poVlaSXAX4naHfbQGPQVGhMz3j4LMptDX1q0XiRcgesAHGYz5IZ
9iT46m8OcpWxZTarrAN0p3ziGEUDkXyqHZwotHFBpGnbKO+fkkboJRoMPtPvmmHB
pKxA6mrXOco38YWVNM3zQ/+u8k5D48UlLxzO0rfcoOvNzPwoy7GQ5UoJFKNNLnF8
qUCnFBRbcfQDAvqbqOOkg6zEoehb2hxtRCbANGu7seWt3ssw2J0IpI5iDSAsNsed
WQqLdc29+tET5/q2JTVw6OA6ge5l1RZcnLKPqtGpvrDrPH3P6CZSUToOMxu2sP+q
scJYa8Rqrydid/7nJ6Z+FjR/gAUflKVbbLnKmwqaUiYFbumKp8xqoPtxeOAIZm0V
G9iuTEBeMjeLG+JaeNI1PTuuuIEd5L01huFuOKpW1FLa+YXN+e/L9v7yCtOGkdxy
FuXyTd0gpgLKLG9CSOWd0zOQG8WtVvWM0n95DYloGzD9nGeRhoJuVYVTlUg7GxL7
UG2k+GkbbhynHYo6QR/vnVCRLEKG23+mgCElfpXrbmY2P/wqtHm30agWj15quzRI
XF+YF38XPzDOXCB7EPCqhJGTlCSECaqacYcu4vnJRPX7puMOdlw=
=W19q
-----END PGP SIGNATURE-----
--=-=-=--

--===============0342389993==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs
IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs

--===============0342389993==--