From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [RFC 1/7] drm/gem: Add drm_gem_dumb_map_offset() Date: Wed, 19 Jul 2017 14:01:40 -0700 Message-ID: <87h8y8dtu3.fsf@eliezer.anholt.net> References: <1499867165-60925-1-git-send-email-noralf@tronnes.org> <1499867165-60925-2-git-send-email-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0954272319==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id EA6066E5A4 for ; Wed, 19 Jul 2017 21:01:45 +0000 (UTC) In-Reply-To: <1499867165-60925-2-git-send-email-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0954272319== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noralf Tr=C3=B8nnes writes: > Add a common drm_driver.dumb_map_offset function for GEM backed drivers. > > Signed-off-by: Noralf Tr=C3=B8nnes Instead of just introducing the new code, could we replace CMA's code with calls to this at the same time? I suspect that if we had CMA subclass from drm_fb_gem (or we move the gem objects to the base class), we could remove a lot of its code that you're copying in patch 2, as well. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAllvyLQACgkQtdYpNtH8 nujcHQ/8C2Oe16FmM9azTrPhcrxAXlf/WDDlQRFsUgDukQwMmN4jGTXsaesYCGb3 t9aX6aEMfZ8/5ZIGYpsnsGtaU7ZAVLMP5uPKGn6XW414jfXsKdHlP2/EncmiCJTB AloIN/LVf7ucq82yjo5FdNP+JX5q16YZLIlbl9RGtso+0nbs4XdkhC6cOWRiHgZj 1YGaSzBWw6V3JmlBuoXhFU7+x3cVP1J07lKZ6zKovCzg2za3CFI3IaEUYkGKobut NqyLTcuh9ZhCaFIQwyeyQ5RecJFMc+xeSCHaU92oLUoVx1SQx94kJOA6c21waSjH A7Y9vPswgBQ6luGbJ7N4eyIMZ2G2MXT9gdLKRk0TK263TkLzV4ouW55VfrKOh32c OB/UIrt3FvC1n90YkLziLOZZ35GtYFHYtqsQlPt1BJRt8gsdOYuFcDS32Zb/ZX+t K3AgailHN1NC4CppI7W22pH4kQYAoCcAn3r2+qzDKbOH51kshWsOVZpW6MzTtgey op74n3QYyAC+vmArAyYAg4U/oiASojajyoXTZUqjuMOVujbANGoxhhrGiFYW9+a4 02Gblxm+FvHxH0wo/3g+ncxjlCp/96GFyOYjPSGLgI1Kb3OFIvwmCK4Cl9xnz2U9 LTblUFzCO7BGq9xc8U+4NWTAp938O25aU2WiWfaujVQhFkkRIvQ= =KzwY -----END PGP SIGNATURE----- --=-=-=-- --===============0954272319== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0954272319==--