From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rasmus Villemoes Subject: Re: [RFC 1/7] drm/amdkfd: avoid fragile and inefficient snprintf use Date: Mon, 14 Mar 2016 20:18:36 +0100 Message-ID: <87h9g8eulv.fsf@rasmusvillemoes.dk> References: <1457469654-17059-1-git-send-email-linux@rasmusvillemoes.dk> <1457469654-17059-2-git-send-email-linux@rasmusvillemoes.dk> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: (Oded Gabbay's message of "Mon, 14 Mar 2016 16:33:18 +0200") Sender: linux-kernel-owner@vger.kernel.org To: Oded Gabbay Cc: Kees Cook , Andrew Morton , David Airlie , Maling list - DRI developers , "Linux-Kernel@Vger. Kernel. Org" , One Thousand Gnomes , Andy Shevchenko , Kalle Valo , Greg Kroah-Hartman , Joe Perches List-Id: dri-devel@lists.freedesktop.org On Mon, Mar 14 2016, Oded Gabbay wrote: > On Tue, Mar 8, 2016 at 10:40 PM, Rasmus Villemoes > wrote: >> Passing overlapping source and destination buffers to snprintf >> formally has undefined behaviour and is rather fragile. While the > > I saw there were some different opinions on this. > Have the fixes to the other drivers been taken ? > I rewrote this (as well as the joystick/analog.c and wlcore/boot.c patches) to use seq_buf, and this patch in particular became much simpler. But since akpm and Alan don't think there's anything to fix I'm going to drop the series; if anyone wants to pursue this I'll be happy to send them my v2. Rasmus