From: Jani Nikula <jani.nikula@linux.intel.com>
To: Harry Wentland <hwentlan@amd.com>,
Manasi Navare <manasi.d.navare@intel.com>
Cc: "Kazlauskas, Nicholas" <Nicholas.Kazlauskas@amd.com>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits
Date: Tue, 14 Jan 2020 15:38:15 +0200 [thread overview]
Message-ID: <87imlekvjs.fsf@intel.com> (raw)
In-Reply-To: <5d1ef8d1-4ef2-6b85-2893-d1c2276e4b70@amd.com>
On Tue, 14 Jan 2020, Harry Wentland <hwentlan@amd.com> wrote:
> Fixing Nick's email.
>
> On 2020-01-10 5:43 p.m., Manasi Navare wrote:
>> On Thu, Jan 09, 2020 at 05:24:30PM +0200, Jani Nikula wrote:
>>> On Tue, 07 Jan 2020, Manasi Navare <manasi.d.navare@intel.com> wrote:
>>>> +EXPORT_SYMBOL(drm_get_adaptive_sync_limits);
>>>
>>> Why the export? Rather, why is this not static?
>>>
>>
>> I could make it static but since the way AMDGPU code is written right now they
>> would be calling this function explicitly to populate the vmin and vmax in their local
>> structs but I can make it static and with some minor refactoring they should be able to
>> use thsi infor directly from drm_display_info
>>
>
> Calling this through drm_add_edid_modes should be sufficient for us.
> We'll just need to move amdgpu_dm_update_freesync_caps to our get_modes
> function.
>
> Dropping the export here seems to be the right thing to do.
Thanks; this should help unify the behaviour across drivers.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-01-14 13:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 0:32 [PATCH v2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits Manasi Navare
2020-01-08 18:46 ` Manasi Navare
2020-01-09 13:08 ` Ville Syrjälä
2020-01-10 23:17 ` Manasi Navare
2020-01-14 0:39 ` Manasi Navare
2020-01-14 13:07 ` Ville Syrjälä
2020-01-15 0:00 ` Manasi Navare
2020-02-28 21:18 ` Manasi Navare
2020-02-29 2:38 ` Manasi Navare
2020-03-02 14:15 ` Kazlauskas, Nicholas
2020-03-02 20:09 ` Manasi Navare
2020-01-09 15:24 ` Jani Nikula
2020-01-10 22:43 ` Manasi Navare
2020-01-14 13:31 ` Harry Wentland
2020-01-14 13:38 ` Jani Nikula [this message]
2020-01-15 0:02 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imlekvjs.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hwentlan@amd.com \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox