From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH] drm/scdc: Fix typo in bit definition of SCDC_STATUS_FLAGS Date: Tue, 22 Oct 2019 12:51:00 +0300 Message-ID: <87imohf6rf.fsf@intel.com> References: <20191016123342.19119-1-patrik.r.jakobsson@gmail.com> <87lftdfb4c.fsf@intel.com> <20191022084423.GB1531961@ulmo> Mime-Version: 1.0 Content-Type: text/plain Return-path: In-Reply-To: <20191022084423.GB1531961@ulmo> Sender: linux-kernel-owner@vger.kernel.org To: Thierry Reding Cc: Patrik Jakobsson , dri-devel@lists.freedesktop.org, Thierry Reding , David Airlie , Sean Paul , linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On Tue, 22 Oct 2019, Thierry Reding wrote: > On Tue, Oct 22, 2019 at 11:16:51AM +0300, Jani Nikula wrote: >> On Wed, 16 Oct 2019, Patrik Jakobsson wrote: >> > Fix typo where bits got compared (x < y) instead of shifted (x << y). >> >> Fixes: 3ad33ae2bc80 ("drm: Add SCDC helpers") >> Cc: Thierry Reding > > I'm not sure we really need the Fixes: tag here. These defines aren't > used anywhere, so technically there's no bug. Yeah well, I just logged it here as I happened to do the drive-by git blame. BR, Jani. > > Thierry > >> >> > Signed-off-by: Patrik Jakobsson >> > --- >> > include/drm/drm_scdc_helper.h | 6 +++--- >> > 1 file changed, 3 insertions(+), 3 deletions(-) >> > >> > diff --git a/include/drm/drm_scdc_helper.h b/include/drm/drm_scdc_helper.h >> > index f92eb2094d6b..6a483533aae4 100644 >> > --- a/include/drm/drm_scdc_helper.h >> > +++ b/include/drm/drm_scdc_helper.h >> > @@ -50,9 +50,9 @@ >> > #define SCDC_READ_REQUEST_ENABLE (1 << 0) >> > >> > #define SCDC_STATUS_FLAGS_0 0x40 >> > -#define SCDC_CH2_LOCK (1 < 3) >> > -#define SCDC_CH1_LOCK (1 < 2) >> > -#define SCDC_CH0_LOCK (1 < 1) >> > +#define SCDC_CH2_LOCK (1 << 3) >> > +#define SCDC_CH1_LOCK (1 << 2) >> > +#define SCDC_CH0_LOCK (1 << 1) >> > #define SCDC_CH_LOCK_MASK (SCDC_CH2_LOCK | SCDC_CH1_LOCK | SCDC_CH0_LOCK) >> > #define SCDC_CLOCK_DETECT (1 << 0) >> >> -- >> Jani Nikula, Intel Open Source Graphics Center >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel -- Jani Nikula, Intel Open Source Graphics Center