From: Jani Nikula <jani.nikula@intel.com>
To: "Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Manasi Navare" <manasi.d.navare@intel.com>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
Date: Tue, 09 Oct 2018 17:32:49 +0300 [thread overview]
Message-ID: <87in2bnqb2.fsf@intel.com> (raw)
In-Reply-To: <20181009134351.GI9144@intel.com>
On Tue, 09 Oct 2018, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
> On Mon, Oct 08, 2018 at 05:23:51PM -0700, Manasi Navare wrote:
>> VESA eDP 1.4 specification has separate fields defined in
>> EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions.
>> This patch defines those. Found this when one of my eDP panels
>> advertises eDP 1.4a (04h) in the EDP_DPCD_REV DPCD field.
>>
>> Cc: Jani Nikula <jani.nikula@intel.com>
>> Cc: Ville Syrjala <ville.syrjala@linux.intel.com>
>> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
>> ---
>> include/drm/drm_dp_helper.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper.h
>> index 2a3843f248cf..9ad98e8d9ede 100644
>> --- a/include/drm/drm_dp_helper.h
>> +++ b/include/drm/drm_dp_helper.h
>> @@ -685,6 +685,8 @@
>> # define DP_EDP_12 0x01
>> # define DP_EDP_13 0x02
>> # define DP_EDP_14 0x03
>> +# define DP_EDP_14a 0x04 /* eDP 1.4a */
>> +# define DP_EDP_14b 0x05 /* eDP 1.4b */
>
> The comments seem a bit redundant.
>
> Either way
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
So I guess we'll need code changing our == checks to >= checks.
BR,
Jani.
>
>>
>> #define DP_EDP_GENERAL_CAP_1 0x701
>> # define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)
>> --
>> 2.18.0
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-10-09 14:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-09 0:23 [PATCH] drm/dp: Add definitions for eDP Rev 1.4a and 1.4b Manasi Navare
2018-10-09 13:43 ` Ville Syrjälä
2018-10-09 14:32 ` Jani Nikula [this message]
2018-10-09 19:32 ` Manasi Navare
2018-10-09 19:34 ` Manasi Navare
2018-10-20 0:18 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in2bnqb2.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox