From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH v3 22/23] drm: vc4: use vblank hooks in struct drm_crtc_funcs Date: Wed, 08 Feb 2017 11:56:21 -0800 Message-ID: <87inoke9sq.fsf@eliezer.anholt.net> References: <1486458995-31018-1-git-send-email-shawnguo@kernel.org> <1486458995-31018-23-git-send-email-shawnguo@kernel.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0300460339==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 234426E99C for ; Wed, 8 Feb 2017 19:56:24 +0000 (UTC) In-Reply-To: <1486458995-31018-23-git-send-email-shawnguo@kernel.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Shawn Guo , Daniel Vetter Cc: Neil Armstrong , Liviu Dudau , Laurent Pinchart , Daniel Vetter , Marek Vasut , Alexey Brodkin , Russell King , Xinliang Liu , Tomi Valkeinen , Mali DP Maintainers , Ben Skeggs , Jyri Sarha , dri-devel@lists.freedesktop.org, Maxime Ripard List-Id: dri-devel@lists.freedesktop.org --===============0300460339== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Shawn Guo writes: > From: Shawn Guo > > The vblank hooks in struct drm_driver are deprecated and only meant for > legacy drivers. For modern drivers with DRIVER_MODESET flag, the hooks > in struct drm_crtc_funcs should be used instead. Thanks for doing this cleanup! Reviewed-by: Eric Anholt --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlibd+UACgkQtdYpNtH8 nugejw//TAn5HOO7z9kpfx0QoYLu/RClv+GzoDpHuySa+pUB0Gxbg27Nlg7i1Zm+ bvGxx9uzA5n77hdcVr1BbdX+jX4yVnzobFl4QhYB0ZSEuMc2jBOOLi+k7TtjWOTP wgc4UyYU7icBT2M3G2JHRGRNEFRS2cXMIc0CHXKvbAoopamebiH2oY5eMAvmln+p nRzB2aBXRZh5WuhGEFq7s+zhi+Z0200926hQhbo3T2y4OSvWqeuuqoIISiZjs9DQ duBAB7mFtFuq+osyVI4hPF7SHPzRVRhhsoHRMtdCQKXBdy78KBViko+ZAQlVN0Vo R+4bhLfisd4v7/2+S7Tp8cqwXxteNWMMvF/96QFc/ybWzTLBODByKu+eaRGiMciz WjQcYi7psjjtaDYa4AlzRokn0ddAgOJQC1rDxBsO6qS7drZbhYUy0W8jZQt5TdS3 LCmLdq7CqXGx2MgVjwb8lr/AL/x1j+WbK5U+mFMjG277hs257nrIcBHErVq4oco9 VzCnVkqwUopOwz3DofaxVd/vkwoFpulc57Xu9a0/NjhGt4teRCtydVoPSjM0cInC /6exQKFtPrM9WyTh0c3tgxCFddQe5pgciVvc3KSyBlAmXthL5S6e7EMiRt0lm5g5 kIXiG951BXSS4v1ESfuKEdoQayei2p74+DTiAeKtt8lWnnQqMVI= =UimL -----END PGP SIGNATURE----- --=-=-=-- --===============0300460339== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0300460339==--