From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [PATCH v11 3/4] drm/i915: Use new CRC debugfs API
Date: Mon, 14 Nov 2016 12:44:25 +0200
Message-ID: <87inrq2vee.fsf@intel.com>
References: <1475767268-14379-1-git-send-email-tomeu.vizoso@collabora.com>
 <1475767268-14379-4-git-send-email-tomeu.vizoso@collabora.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <1475767268-14379-4-git-send-email-tomeu.vizoso@collabora.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: linux-kernel@vger.kernel.org
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>, David Airlie <airlied@linux.ie>, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Thierry Reding <thierry.reding@gmail.com>, Daniel Vetter <daniel.vetter@intel.com>
List-Id: dri-devel@lists.freedesktop.org

T24gVGh1LCAwNiBPY3QgMjAxNiwgVG9tZXUgVml6b3NvIDx0b21ldS52aXpvc29AY29sbGFib3Jh
LmNvbT4gd3JvdGU6Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp
c3BsYXkuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+IGluZGV4IDIz
YTZjNzIxM2VjYS4uNzQxMmEwNWZhNWQ5IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2ludGVsX2Rpc3BsYXkuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rp
c3BsYXkuYwo+IEBAIC0xNDYzNiw2ICsxNDYzNiw3IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJt
X2NydGNfZnVuY3MgaW50ZWxfY3J0Y19mdW5jcyA9IHsKPiAgCS5wYWdlX2ZsaXAgPSBpbnRlbF9j
cnRjX3BhZ2VfZmxpcCwKPiAgCS5hdG9taWNfZHVwbGljYXRlX3N0YXRlID0gaW50ZWxfY3J0Y19k
dXBsaWNhdGVfc3RhdGUsCj4gIAkuYXRvbWljX2Rlc3Ryb3lfc3RhdGUgPSBpbnRlbF9jcnRjX2Rl
c3Ryb3lfc3RhdGUsCj4gKwkuc2V0X2NyY19zb3VyY2UgPSBpbnRlbF9jcnRjX3NldF9jcmNfc291
cmNlLAo+ICB9Owo+ICAKPiAgLyoqCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX2Rydi5oIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHJ2LmgKPiBpbmRleCA3
MzcyNjFiMDkxMTAuLjMxODk0YjdjNjUxNyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF9kcnYuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rydi5o
Cj4gQEAgLTE4NDQsNiArMTg0NCwxNCBAQCB2b2lkIGludGVsX2NvbG9yX2xvYWRfbHV0cyhzdHJ1
Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGUpOwo+ICAvKiBpbnRlbF9waXBlX2NyYy5jICov
Cj4gIGludCBpbnRlbF9waXBlX2NyY19jcmVhdGUoc3RydWN0IGRybV9taW5vciAqbWlub3IpOwo+
ICB2b2lkIGludGVsX3BpcGVfY3JjX2NsZWFudXAoc3RydWN0IGRybV9taW5vciAqbWlub3IpOwo+
ICsjaWZkZWYgQ09ORklHX0RFQlVHX0ZTCj4gK2ludCBpbnRlbF9jcnRjX3NldF9jcmNfc291cmNl
KHN0cnVjdCBkcm1fY3J0YyAqY3J0YywgY29uc3QgY2hhciAqc291cmNlX25hbWUsCj4gKwkJCSAg
ICAgIHNpemVfdCAqdmFsdWVzX2NudCk7Cj4gKyNlbHNlCj4gK3N0YXRpYyBpbmxpbmUgaW50IGlu
dGVsX2NydGNfc2V0X2NyY19zb3VyY2Uoc3RydWN0IGRybV9jcnRjICpjcnRjLAo+ICsJCQkJCSAg
ICBjb25zdCBjaGFyICpzb3VyY2VfbmFtZSwKPiArCQkJCQkgICAgc2l6ZV90ICp2YWx1ZXNfY250
KSB7IHJldHVybiAwOyB9Cj4gKyNlbmRpZgoKImlubGluZSIgaGVyZSBkb2Vzbid0IHdvcmsgYmVj
YXVzZSBpdCdzIHVzZWQgYXMgYSBmdW5jdGlvbiBwb2ludGVyLgoKSXMgaXQgYmV0dGVyIHRvIGhh
dmUgYSBmdW5jdGlvbiB0aGF0IHJldHVybnMgMCBmb3IgLnNldF9jcmNfc291cmNlLCBvcgp0byBz
ZXQgLnNldF9jcmNfc291cmNlIHRvIE5VTEwgd2hlbiBDT05GSUdfREVCVUdfRlM9bj8KCkJSLApK
YW5pLgoKCj4gIGV4dGVybiBjb25zdCBzdHJ1Y3QgZmlsZV9vcGVyYXRpb25zIGk5MTVfZGlzcGxh
eV9jcmNfY3RsX2ZvcHM7Cj4gIAo+ICAjZW5kaWYgLyogX19JTlRFTF9EUlZfSF9fICovCj4gZGlm
ZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMgYi9kcml2ZXJz
L2dwdS9kcm0vaTkxNS9pbnRlbF9waXBlX2NyYy5jCj4gaW5kZXggNmMzOGQ0ZmRjYWVmLi4xYTUx
ZTE3NGU5ZTUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcGlwZV9j
cmMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3BpcGVfY3JjLmMKPiBAQCAt
NjE1LDYgKzYxNSwyMiBAQCBzdGF0aWMgaW50IGl2Yl9waXBlX2NyY19jdGxfcmVnKHN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCXJldHVybiAwOwo+ICB9Cj4gIAo+ICtzdGF0
aWMgaW50IGdldF9uZXdfY3JjX2N0bF9yZWcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9w
cml2LAo+ICsJCQkgICAgICAgZW51bSBwaXBlIHBpcGUsCj4gKwkJCSAgICAgICBlbnVtIGludGVs
X3BpcGVfY3JjX3NvdXJjZSAqc291cmNlLCB1MzIgKnZhbCkKPiArewo+ICsJaWYgKElTX0dFTjIo
ZGV2X3ByaXYpKQo+ICsJCXJldHVybiBpOHh4X3BpcGVfY3JjX2N0bF9yZWcoc291cmNlLCB2YWwp
Owo+ICsJZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDUpCj4gKwkJcmV0dXJuIGk5eHhf
cGlwZV9jcmNfY3RsX3JlZyhkZXZfcHJpdiwgcGlwZSwgc291cmNlLCB2YWwpOwo+ICsJZWxzZSBp
ZiAoSVNfVkFMTEVZVklFVyhkZXZfcHJpdikgfHwgSVNfQ0hFUlJZVklFVyhkZXZfcHJpdikpCj4g
KwkJcmV0dXJuIHZsdl9waXBlX2NyY19jdGxfcmVnKGRldl9wcml2LCBwaXBlLCBzb3VyY2UsIHZh
bCk7Cj4gKwllbHNlIGlmIChJU19HRU41KGRldl9wcml2KSB8fCBJU19HRU42KGRldl9wcml2KSkK
PiArCQlyZXR1cm4gaWxrX3BpcGVfY3JjX2N0bF9yZWcoc291cmNlLCB2YWwpOwo+ICsJZWxzZQo+
ICsJCXJldHVybiBpdmJfcGlwZV9jcmNfY3RsX3JlZyhkZXZfcHJpdiwgcGlwZSwgc291cmNlLCB2
YWwpOwo+ICt9Cj4gKwo+ICBzdGF0aWMgaW50IHBpcGVfY3JjX3NldF9zb3VyY2Uoc3RydWN0IGRy
bV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJCQkgICAgICAgZW51bSBwaXBlIHBpcGUsCj4g
IAkJCSAgICAgICBlbnVtIGludGVsX3BpcGVfY3JjX3NvdXJjZSBzb3VyY2UpCj4gQEAgLTY0MCwx
NyArNjU2LDcgQEAgc3RhdGljIGludCBwaXBlX2NyY19zZXRfc291cmNlKHN0cnVjdCBkcm1faTkx
NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlyZXR1cm4gLUVJTzsKPiAgCX0KPiAgCj4gLQlpZiAo
SVNfR0VOMihkZXZfcHJpdikpCj4gLQkJcmV0ID0gaTh4eF9waXBlX2NyY19jdGxfcmVnKCZzb3Vy
Y2UsICZ2YWwpOwo+IC0JZWxzZSBpZiAoSU5URUxfR0VOKGRldl9wcml2KSA8IDUpCj4gLQkJcmV0
ID0gaTl4eF9waXBlX2NyY19jdGxfcmVnKGRldl9wcml2LCBwaXBlLCAmc291cmNlLCAmdmFsKTsK
PiAtCWVsc2UgaWYgKElTX1ZBTExFWVZJRVcoZGV2X3ByaXYpIHx8IElTX0NIRVJSWVZJRVcoZGV2
X3ByaXYpKQo+IC0JCXJldCA9IHZsdl9waXBlX2NyY19jdGxfcmVnKGRldl9wcml2LCBwaXBlLCAm
c291cmNlLCAmdmFsKTsKPiAtCWVsc2UgaWYgKElTX0dFTjUoZGV2X3ByaXYpIHx8IElTX0dFTjYo
ZGV2X3ByaXYpKQo+IC0JCXJldCA9IGlsa19waXBlX2NyY19jdGxfcmVnKCZzb3VyY2UsICZ2YWwp
Owo+IC0JZWxzZQo+IC0JCXJldCA9IGl2Yl9waXBlX2NyY19jdGxfcmVnKGRldl9wcml2LCBwaXBl
LCAmc291cmNlLCAmdmFsKTsKPiAtCj4gKwlyZXQgPSBnZXRfbmV3X2NyY19jdGxfcmVnKGRldl9w
cml2LCBwaXBlLCAmc291cmNlLCAmdmFsKTsKPiAgCWlmIChyZXQgIT0gMCkKPiAgCQlnb3RvIG91
dDsKPiAgCj4gQEAgLTY5MSw3ICs2OTcsNyBAQCBzdGF0aWMgaW50IHBpcGVfY3JjX3NldF9zb3Vy
Y2Uoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2LAo+ICAJUE9TVElOR19SRUFEKFBJ
UEVfQ1JDX0NUTChwaXBlKSk7Cj4gIAo+ICAJLyogcmVhbCBzb3VyY2UgLT4gbm9uZSB0cmFuc2l0
aW9uICovCj4gLQlpZiAoc291cmNlID09IElOVEVMX1BJUEVfQ1JDX1NPVVJDRV9OT05FKSB7Cj4g
KwlpZiAoIXNvdXJjZSkgewo+ICAJCXN0cnVjdCBpbnRlbF9waXBlX2NyY19lbnRyeSAqZW50cmll
czsKPiAgCQlzdHJ1Y3QgaW50ZWxfY3J0YyAqY3J0YyA9Cj4gIAkJCXRvX2ludGVsX2NydGMoZGV2
X3ByaXYtPnBpcGVfdG9fY3J0Y19tYXBwaW5nW3BpcGVdKTsKPiBAQCAtODEzLDYgKzgxOSwxMSBA
QCBkaXNwbGF5X2NyY19jdGxfcGFyc2Vfc291cmNlKGNvbnN0IGNoYXIgKmJ1ZiwgZW51bSBpbnRl
bF9waXBlX2NyY19zb3VyY2UgKnMpCj4gIHsKPiAgCWludCBpOwo+ICAKPiArCWlmICghYnVmKSB7
Cj4gKwkJKnMgPSBJTlRFTF9QSVBFX0NSQ19TT1VSQ0VfTk9ORTsKPiArCQlyZXR1cm4gMDsKPiAr
CX0KPiArCj4gIAlmb3IgKGkgPSAwOyBpIDwgQVJSQVlfU0laRShwaXBlX2NyY19zb3VyY2VzKTsg
aSsrKQo+ICAJCWlmICghc3RyY21wKGJ1ZiwgcGlwZV9jcmNfc291cmNlc1tpXSkpIHsKPiAgCQkJ
KnMgPSBpOwo+IEBAIC05NDEsMyArOTUyLDYyIEBAIHZvaWQgaW50ZWxfcGlwZV9jcmNfY2xlYW51
cChzdHJ1Y3QgZHJtX21pbm9yICptaW5vcikKPiAgCQlkcm1fZGVidWdmc19yZW1vdmVfZmlsZXMo
aW5mb19saXN0LCAxLCBtaW5vcik7Cj4gIAl9Cj4gIH0KPiArCj4gK2ludCBpbnRlbF9jcnRjX3Nl
dF9jcmNfc291cmNlKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywgY29uc3QgY2hhciAqc291cmNlX25h
bWUsCj4gKwkJCSAgICAgIHNpemVfdCAqdmFsdWVzX2NudCkKPiArewo+ICsJc3RydWN0IGRybV9p
OTE1X3ByaXZhdGUgKmRldl9wcml2ID0gY3J0Yy0+ZGV2LT5kZXZfcHJpdmF0ZTsKPiArCXN0cnVj
dCBpbnRlbF9waXBlX2NyYyAqcGlwZV9jcmMgPSAmZGV2X3ByaXYtPnBpcGVfY3JjW2NydGMtPmlu
ZGV4XTsKPiArCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0Yyhj
cnRjKTsKPiArCWVudW0gaW50ZWxfZGlzcGxheV9wb3dlcl9kb21haW4gcG93ZXJfZG9tYWluOwo+
ICsJZW51bSBpbnRlbF9waXBlX2NyY19zb3VyY2Ugc291cmNlOwo+ICsJdTMyIHZhbCA9IDA7IC8q
IHNodXQgdXAgZ2NjICovCj4gKwlpbnQgcmV0ID0gMDsKPiArCj4gKwlpZiAoZGlzcGxheV9jcmNf
Y3RsX3BhcnNlX3NvdXJjZShzb3VyY2VfbmFtZSwgJnNvdXJjZSkgPCAwKSB7Cj4gKwkJRFJNX0RF
QlVHX0RSSVZFUigidW5rbm93biBzb3VyY2UgJXNcbiIsIHNvdXJjZV9uYW1lKTsKPiArCQlyZXR1
cm4gLUVJTlZBTDsKPiArCX0KPiArCj4gKwlwb3dlcl9kb21haW4gPSBQT1dFUl9ET01BSU5fUElQ
RShjcnRjLT5pbmRleCk7Cj4gKwlpZiAoIWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0X2lmX2VuYWJs
ZWQoZGV2X3ByaXYsIHBvd2VyX2RvbWFpbikpIHsKPiArCQlEUk1fREVCVUdfS01TKCJUcnlpbmcg
dG8gY2FwdHVyZSBDUkMgd2hpbGUgcGlwZSBpcyBvZmZcbiIpOwo+ICsJCXJldHVybiAtRUlPOwo+
ICsJfQo+ICsKPiArCXJldCA9IGdldF9uZXdfY3JjX2N0bF9yZWcoZGV2X3ByaXYsIGNydGMtPmlu
ZGV4LCAmc291cmNlLCAmdmFsKTsKPiArCWlmIChyZXQgIT0gMCkKPiArCQlnb3RvIG91dDsKPiAr
Cj4gKwlpZiAoc291cmNlKSB7Cj4gKwkJLyoKPiArCQkgKiBXaGVuIElQUyBnZXRzIGVuYWJsZWQs
IHRoZSBwaXBlIENSQyBjaGFuZ2VzLiBTaW5jZSBJUFMgZ2V0cwo+ICsJCSAqIGVuYWJsZWQgYW5k
IGRpc2FibGVkIGR5bmFtaWNhbGx5IGJhc2VkIG9uIHBhY2thZ2UgQyBzdGF0ZXMsCj4gKwkJICog
dXNlciBzcGFjZSBjYW4ndCBtYWtlIHJlbGlhYmxlIHVzZSBvZiB0aGUgQ1JDcywgc28gbGV0J3Mg
anVzdAo+ICsJCSAqIGNvbXBsZXRlbHkgZGlzYWJsZSBpdC4KPiArCQkgKi8KPiArCQloc3dfZGlz
YWJsZV9pcHMoaW50ZWxfY3J0Yyk7Cj4gKwl9Cj4gKwo+ICsJSTkxNV9XUklURShQSVBFX0NSQ19D
VEwoY3J0Yy0+aW5kZXgpLCB2YWwpOwo+ICsJUE9TVElOR19SRUFEKFBJUEVfQ1JDX0NUTChjcnRj
LT5pbmRleCkpOwo+ICsKPiArCWlmICghc291cmNlKSB7Cj4gKwkJaWYgKElTX0c0WChkZXZfcHJp
dikpCj4gKwkJCWc0eF91bmRvX3BpcGVfc2NyYW1ibGVfcmVzZXQoZGV2X3ByaXYsIGNydGMtPmlu
ZGV4KTsKPiArCQllbHNlIGlmIChJU19WQUxMRVlWSUVXKGRldl9wcml2KSB8fCBJU19DSEVSUllW
SUVXKGRldl9wcml2KSkKPiArCQkJdmx2X3VuZG9fcGlwZV9zY3JhbWJsZV9yZXNldChkZXZfcHJp
diwgY3J0Yy0+aW5kZXgpOwo+ICsJCWVsc2UgaWYgKElTX0hBU1dFTEwoZGV2X3ByaXYpICYmIGNy
dGMtPmluZGV4ID09IFBJUEVfQSkKPiArCQkJaHN3X3RyYW5zX2VkcF9waXBlX0FfY3JjX3dhKGRl
dl9wcml2LCBmYWxzZSk7Cj4gKwo+ICsJCWhzd19lbmFibGVfaXBzKGludGVsX2NydGMpOwo+ICsJ
fQo+ICsKPiArCXBpcGVfY3JjLT5za2lwcGVkID0gMDsKPiArCSp2YWx1ZXNfY250ID0gNTsKPiAr
Cj4gK291dDoKPiArCWludGVsX2Rpc3BsYXlfcG93ZXJfcHV0KGRldl9wcml2LCBwb3dlcl9kb21h
aW4pOwo+ICsKPiArCXJldHVybiByZXQ7Cj4gK30KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3Bl
biBTb3VyY2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vaW50ZWwtZ2Z4Cg==