From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH v5 4/5] drm: Add library for shmem backed
 GEM objects
Date: Mon, 26 Nov 2018 16:36:21 -0800
Message-ID: <87k1kzgxve.fsf@anholt.net>
References: <20181017130454.44292-1-noralf@tronnes.org>
 <20181017130454.44292-5-noralf@tronnes.org>
Mime-Version: 1.0
Content-Type: multipart/mixed; boundary="===============1553694818=="
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
In-Reply-To: <20181017130454.44292-5-noralf@tronnes.org>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= <noralf@tronnes.org>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org, sam@ravnborg.org, david@lechnology.com
List-Id: dri-devel@lists.freedesktop.org

--===============1553694818==
Content-Type: multipart/signed; boundary="=-=-=";
	micalg=pgp-sha512; protocol="application/pgp-signature"

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Noralf Tr=C3=B8nnes <noralf@tronnes.org> writes:
> +static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)
> +{
> +	struct drm_gem_object *obj =3D vma->vm_private_data;
> +	struct drm_gem_shmem_object *shmem =3D to_drm_gem_shmem_obj(obj);
> +
> +	drm_gem_shmem_put_pages(shmem);
> +	drm_gem_vm_close(vma);
> +}
> +
> +const struct vm_operations_struct drm_gem_shmem_vm_ops =3D {
> +	.fault =3D drm_gem_shmem_fault,
> +	.open =3D drm_gem_vm_open,
> +	.close =3D drm_gem_shmem_vm_close,
> +};
> +EXPORT_SYMBOL_GPL(drm_gem_shmem_vm_ops);

I just saw a warning from drm_gem_shmem_put_pages() for
!shmem->pages_use_count -- I think drm_gem_vm_open() needs to
drm_gem_shmem_get_pages().

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlv8kYUACgkQtdYpNtH8
nuiesw/9H6VAyGfqD+d6vVaowITnKZzucvqTaFJyCrAQz+8onYQsJh9v90TM54E2
DIAiKtHz8E/04myoSDxIELROyxIaxExixe0BpI5k4GtEyy1OUq08rb+tkwxxAeNe
k0TuY9YGBehPX2kFLnM9zCviqglmsSlavxZy2iWN0FEOvumuIQ/wekyDxjnMCU6J
gk7L1k93bGlXHSkL2N63WX6QKJF45Y8BfAswcFApq4dnACL9S2qgxzf/bLV+/eXU
NNpf5iXbqqfZbQpra8RqBODrPtzdpFvVWwPyOzBOcc20ILsMv0wal2AtZCDy89+4
UPrgyrmdJ1j6R0QniSUY/UqyOuSbpvrWlI43IX2HXw/jsgRE3hfDA0vsmtveunHF
4K0pqqD6QH3toaKznNvl4OHPvtdwNxD9sDP7EmSdjYuKvN4sBMQ6VCNSuANr2bia
faR3TmRwtDFV1fOKAoJIgs+vh/kqLQaCmahTogjgGCeHtxurOdOW2cDfMDifVAOD
oZSSHJwZXEZ8kcSyeIBSII9RnV4BPFNtQwurk2VPR8fUPgZggEIRXrBHW4QkxD0G
LCJ7p36CfBt5Z43OvfN0MM/TfIuAFborqkbwn5bGIDEoJTRYzwROI4rPxWfFgrZU
6DkvZI05UyL59TEMdZUB5zHgqaFg5BP3v2hHf4VApoRSa0tqfzs=
=ila/
-----END PGP SIGNATURE-----
--=-=-=--

--===============1553694818==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: base64
Content-Disposition: inline

X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4
IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz
dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==

--===============1553694818==--