From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: -EPROBE_DEFER and failed DSI panel probe Date: Wed, 15 Nov 2017 12:26:48 -0800 Message-ID: <87k1yr9tkn.fsf@anholt.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0574408405==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id EF89F6E6BB for ; Wed, 15 Nov 2017 20:26:51 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 9CD7310A164E for ; Wed, 15 Nov 2017 12:26:50 -0800 (PST) Received: from anholt.net ([127.0.0.1]) by localhost (kingsolver.anholt.net [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 69Zz0sgat6rV for ; Wed, 15 Nov 2017 12:26:49 -0800 (PST) Received: from eliezer.anholt.net (localhost [127.0.0.1]) by anholt.net (Postfix) with ESMTP id 88E8110A047D for ; Wed, 15 Nov 2017 12:26:49 -0800 (PST) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0574408405== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain I'm happy to have the DSI panel finally working on VC4 (just waiting on https://lists.freedesktop.org/archives/dri-devel/2017-October/156407.html), but now I've got another problem to solve. It would be great if I could include the DSI panel in our upstream DT, so that it automatically worked when you plugged one in. However, right now we return -EPROBE_DEFER during bind unless the panel has actually shown up. This means that if you don't have the panel actually connected, you get this sequence at startup: [ 10.719929] [drm] Initialized [ 10.829510] vc4_hdmi 3f902000.hdmi: vc4-hdmi-hifi <-> 3f902000.hdmi mapping ok [ 10.844043] vc4-drm soc:gpu: bound 3f902000.hdmi (ops vc4_hdmi_ops [vc4]) [ 10.848626] vc4-drm soc:gpu: bound 3f806000.vec (ops vc4_vec_ops [vc4]) [ 10.850214] vc4-drm soc:gpu: failed to bind 3f700000.dsi (ops vc4_dsi_ops [vc4]): -517 [ 10.856559] vc4-drm soc:gpu: master bind failed: -517 [...] [ 10.967718] rpi_touchscreen 3-0045: Atmel I2C read failed: -6 Once the panel driver fails to probe, we never get asked to re-bind vc4, and drm_of_find_panel_or_bridge looks like it would just give us -EPROBE_DEFER again since the panel still wasn't registered. Does anyone have any suggestions for handling this? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAloMowgACgkQtdYpNtH8 nujcDhAAimAzEFRbtTGDzTMCj+n5uepsRUexUMzF0yVaBTmk3HsgoUFyqL1AXRf5 FICiK1PElEg3/7QY+xIQXQMJMQ12/E8V/7CsVl6tBpBNjYdv9bApCh1/6rEc3ru4 9Xc2+V3tjvn38LbSQtUnpNiASCbnnVxHvKLz41sMQ8LQjndJVk4m2I5MbT3L3IOL q1btcIszsxb8Kh1tTBvAcyRZqk1Ja7JTOs4AH4m9+ZwZHTUCkUfxVv7RA50KcGAH zEG7lco27AS5bqertPJOM01rqOZF1pNO6wBan+qLoT6WWpBvUiQdNpF9q+DmS95m a5KzvozWuN8d9w8D3UZOry7RdGVcfTkFQ/1u5mJl0xvkc0iVkPAlkPltMv4e981P y3pB/9OfCSh1DDGUFdUyhNp2hVyezW+ksBGvVo63CttlBUtj2j6VoTejtfaijsdE LpQc+oL5CkYfqK77xgS7vuMsjz57y269Kv/IeL6iZQHzCew5G6zSA/SLOug0AQsd RNwVBrWszsJlQXqKoiT8D7sEzhvRY1zAgMqE6JJGOUgRciitzbh2Sk4itgNtSf/i p2A9t1hOB+/4YhWEXVLZ2OUJVjr8qW8uz12bBBXfxmogHycvsGyvjfs7oTej2dgO Wufwqx7AsLNCgAsWxbsfm1ObWWrLsEyto9SGefwpdjLRQ69Inc8= =ors7 -----END PGP SIGNATURE----- --=-=-=-- --===============0574408405== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0574408405==--