From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: [Outreachy kernel] [PATCH v2 3/3] drm: Remove assignment in if
 condition
Date: Thu, 14 Sep 2017 09:13:04 +0300
Message-ID: <87k211iz9r.fsf@nikula.org>
References: <20170913161531.GA3239@meghana-HP-Pavilion-Notebook>
 <alpine.DEB.2.20.1709132222370.2920@hadrien>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id A9F386E947
 for <dri-devel@lists.freedesktop.org>; Thu, 14 Sep 2017 06:13:29 +0000 (UTC)
In-Reply-To: <alpine.DEB.2.20.1709132222370.2920@hadrien>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Julia Lawall <julia.lawall@lip6.fr>, Meghana Madhyastha <meghana.madhyastha@gmail.com>
Cc: outreachy-kernel@googlegroups.com, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

T24gV2VkLCAxMyBTZXAgMjAxNywgSnVsaWEgTGF3YWxsIDxqdWxpYS5sYXdhbGxAbGlwNi5mcj4g
d3JvdGU6Cj4gT24gV2VkLCAxMyBTZXAgMjAxNywgTWVnaGFuYSBNYWRoeWFzdGhhIHdyb3RlOgo+
Cj4+IE1vdmUgdGhlIGFzc2lnbm1lbnQgc28gdGhhdCBpdCBoYXBwZW5zIGJlZm9yZSB0aGUgaWYK
Pj4gY29uZGl0aW9uLiBUaGlzIHJlc3VsdHMgaW4gc3ludGF4IHdoaWNoIGlzIGVhc2llciB0byBy
ZWFkLgo+Cj4gSXQgd291bGQgYmUgbmljZSB0byBtZW50aW9uIHRoZSBtZXJnZWQgY29uZGl0aW9u
YWxzIGluIHRoZSBsb2cgbWVzc2FnZS4KCkVpdGhlciB3YXksCgpSZXZpZXdlZC1ieTogSmFuaSBO
aWt1bGEgPGphbmkubmlrdWxhQGludGVsLmNvbT4KCj4KPiBqdWxpYQo+Cj4+IEZvdW5kIGJ5IGNo
ZWNrcGF0aC5wbAo+Pgo+PiBTaWduZWQtb2ZmLWJ5OiBNZWdoYW5hIE1hZGh5YXN0aGEgPG1lZ2hh
bmEubWFkaHlhc3RoYUBnbWFpbC5jb20+Cj4+IC0tLQo+PiAgZHJpdmVycy9ncHUvZHJtL2RybV9h
Z3BzdXBwb3J0LmMgfCAzMSArKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tCj4+ICAxIGZp
bGUgY2hhbmdlZCwgMTggaW5zZXJ0aW9ucygrKSwgMTMgZGVsZXRpb25zKC0pCj4+Cj4+IGRpZmYg
LS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2FncHN1cHBvcnQuYyBiL2RyaXZlcnMvZ3B1L2Ry
bS9kcm1fYWdwc3VwcG9ydC5jCj4+IGluZGV4IDk5M2U0ODYuLjczN2YwMjggMTAwNjQ0Cj4+IC0t
LSBhL2RyaXZlcnMvZ3B1L2RybS9kcm1fYWdwc3VwcG9ydC5jCj4+ICsrKyBiL2RyaXZlcnMvZ3B1
L2RybS9kcm1fYWdwc3VwcG9ydC5jCj4+IEBAIC0xMDAsNyArMTAwLDggQEAgaW50IGRybV9hZ3Bf
YWNxdWlyZShzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgCQlyZXR1cm4gLUVOT0RFVjsKPj4g
IAlpZiAoZGV2LT5hZ3AtPmFjcXVpcmVkKQo+PiAgCQlyZXR1cm4gLUVCVVNZOwo+PiAtCWlmICgh
KGRldi0+YWdwLT5icmlkZ2UgPSBhZ3BfYmFja2VuZF9hY3F1aXJlKGRldi0+cGRldikpKQo+PiAr
CWRldi0+YWdwLT5icmlkZ2UgPSBhZ3BfYmFja2VuZF9hY3F1aXJlKGRldi0+cGRldik7Cj4+ICsJ
aWYgKCFkZXYtPmFncC0+YnJpZGdlKQo+PiAgCQlyZXR1cm4gLUVOT0RFVjsKPj4gIAlkZXYtPmFn
cC0+YWNxdWlyZWQgPSAxOwo+PiAgCXJldHVybiAwOwo+PiBAQCAtMjAwLDEyICsyMDEsMTQgQEAg
aW50IGRybV9hZ3BfYWxsb2Moc3RydWN0IGRybV9kZXZpY2UgKmRldiwgc3RydWN0IGRybV9hZ3Bf
YnVmZmVyICpyZXF1ZXN0KQo+Pgo+PiAgCWlmICghZGV2LT5hZ3AgfHwgIWRldi0+YWdwLT5hY3F1
aXJlZCkKPj4gIAkJcmV0dXJuIC1FSU5WQUw7Cj4+IC0JaWYgKCEoZW50cnkgPSBremFsbG9jKHNp
emVvZigqZW50cnkpLCBHRlBfS0VSTkVMKSkpCj4+ICsJZW50cnkgPSBremFsbG9jKHNpemVvZigq
ZW50cnkpLCBHRlBfS0VSTkVMKTsKPj4gKwlpZiAoIWVudHJ5KQo+PiAgCQlyZXR1cm4gLUVOT01F
TTsKPj4KPj4gIAlwYWdlcyA9IChyZXF1ZXN0LT5zaXplICsgUEFHRV9TSVpFIC0gMSkgLyBQQUdF
X1NJWkU7Cj4+ICAJdHlwZSA9ICh1MzIpIHJlcXVlc3QtPnR5cGU7Cj4+IC0JaWYgKCEobWVtb3J5
ID0gYWdwX2FsbG9jYXRlX21lbW9yeShkZXYtPmFncC0+YnJpZGdlLCBwYWdlcywgdHlwZSkpKSB7
Cj4+ICsJbWVtb3J5ID0gYWdwX2FsbG9jYXRlX21lbW9yeShkZXYtPmFncC0+YnJpZGdlLCBwYWdl
cywgdHlwZSk7Cj4+ICsJaWYgKCFtZW1vcnkpIHsKPj4gIAkJa2ZyZWUoZW50cnkpOwo+PiAgCQly
ZXR1cm4gLUVOT01FTTsKPj4gIAl9Cj4+IEBAIC0yNzIsOSArMjc1LDggQEAgaW50IGRybV9hZ3Bf
dW5iaW5kKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1fYWdwX2JpbmRpbmcgKnJl
cXVlc3QpCj4+Cj4+ICAJaWYgKCFkZXYtPmFncCB8fCAhZGV2LT5hZ3AtPmFjcXVpcmVkKQo+PiAg
CQlyZXR1cm4gLUVJTlZBTDsKPj4gLQlpZiAoIShlbnRyeSA9IGRybV9hZ3BfbG9va3VwX2VudHJ5
KGRldiwgcmVxdWVzdC0+aGFuZGxlKSkpCj4+IC0JCXJldHVybiAtRUlOVkFMOwo+PiAtCWlmICgh
ZW50cnktPmJvdW5kKQo+PiArCWVudHJ5ID0gZHJtX2FncF9sb29rdXBfZW50cnkoZGV2LCByZXF1
ZXN0LT5oYW5kbGUpOwo+PiArCWlmICghZW50cnkgfHwgIWVudHJ5LT5ib3VuZCkKPj4gIAkJcmV0
dXJuIC1FSU5WQUw7Cj4+ICAJcmV0ID0gZHJtX3VuYmluZF9hZ3AoZW50cnktPm1lbW9yeSk7Cj4+
ICAJaWYgKHJldCA9PSAwKQo+PiBAQCAtMzEzLDEyICszMTUsMTIgQEAgaW50IGRybV9hZ3BfYmlu
ZChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2LCBzdHJ1Y3QgZHJtX2FncF9iaW5kaW5nICpyZXF1ZXN0
KQo+Pgo+PiAgCWlmICghZGV2LT5hZ3AgfHwgIWRldi0+YWdwLT5hY3F1aXJlZCkKPj4gIAkJcmV0
dXJuIC1FSU5WQUw7Cj4+IC0JaWYgKCEoZW50cnkgPSBkcm1fYWdwX2xvb2t1cF9lbnRyeShkZXYs
IHJlcXVlc3QtPmhhbmRsZSkpKQo+PiAtCQlyZXR1cm4gLUVJTlZBTDsKPj4gLQlpZiAoZW50cnkt
PmJvdW5kKQo+PiArCWVudHJ5ID0gZHJtX2FncF9sb29rdXBfZW50cnkoZGV2LCByZXF1ZXN0LT5o
YW5kbGUpOwo+PiArCWlmICghZW50cnkgfHwgZW50cnktPmJvdW5kKQo+PiAgCQlyZXR1cm4gLUVJ
TlZBTDsKPj4gIAlwYWdlID0gKHJlcXVlc3QtPm9mZnNldCArIFBBR0VfU0laRSAtIDEpIC8gUEFH
RV9TSVpFOwo+PiAtCWlmICgocmV0Y29kZSA9IGRybV9iaW5kX2FncChlbnRyeS0+bWVtb3J5LCBw
YWdlKSkpCj4+ICsJcmV0Y29kZSA9IGRybV9iaW5kX2FncChlbnRyeS0+bWVtb3J5LCBwYWdlKTsK
Pj4gKwlpZiAocmV0Y29kZSkKPj4gIAkJcmV0dXJuIHJldGNvZGU7Cj4+ICAJZW50cnktPmJvdW5k
ID0gZGV2LT5hZ3AtPmJhc2UgKyAocGFnZSA8PCBQQUdFX1NISUZUKTsKPj4gIAlEUk1fREVCVUco
ImJhc2UgPSAweCVseCBlbnRyeS0+Ym91bmQgPSAweCVseFxuIiwKPj4gQEAgLTM1Niw3ICszNTgs
OCBAQCBpbnQgZHJtX2FncF9mcmVlKHN0cnVjdCBkcm1fZGV2aWNlICpkZXYsIHN0cnVjdCBkcm1f
YWdwX2J1ZmZlciAqcmVxdWVzdCkKPj4KPj4gIAlpZiAoIWRldi0+YWdwIHx8ICFkZXYtPmFncC0+
YWNxdWlyZWQpCj4+ICAJCXJldHVybiAtRUlOVkFMOwo+PiAtCWlmICghKGVudHJ5ID0gZHJtX2Fn
cF9sb29rdXBfZW50cnkoZGV2LCByZXF1ZXN0LT5oYW5kbGUpKSkKPj4gKwllbnRyeSA9IGRybV9h
Z3BfbG9va3VwX2VudHJ5KGRldiwgcmVxdWVzdC0+aGFuZGxlKTsKPj4gKwlpZiAoIWVudHJ5KQo+
PiAgCQlyZXR1cm4gLUVJTlZBTDsKPj4gIAlpZiAoZW50cnktPmJvdW5kKQo+PiAgCQlkcm1fdW5i
aW5kX2FncChlbnRyeS0+bWVtb3J5KTsKPj4gQEAgLTM5NCwxMSArMzk3LDEzIEBAIHN0cnVjdCBk
cm1fYWdwX2hlYWQgKmRybV9hZ3BfaW5pdChzdHJ1Y3QgZHJtX2RldmljZSAqZGV2KQo+PiAgewo+
PiAgCXN0cnVjdCBkcm1fYWdwX2hlYWQgKmhlYWQgPSBOVUxMOwo+Pgo+PiAtCWlmICghKGhlYWQg
PSBremFsbG9jKHNpemVvZigqaGVhZCksIEdGUF9LRVJORUwpKSkKPj4gKwloZWFkID0ga3phbGxv
YyhzaXplb2YoKmhlYWQpLCBHRlBfS0VSTkVMKTsKPj4gKwlpZiAoIWhlYWQpCj4+ICAJCXJldHVy
biBOVUxMOwo+PiAgCWhlYWQtPmJyaWRnZSA9IGFncF9maW5kX2JyaWRnZShkZXYtPnBkZXYpOwo+
PiAgCWlmICghaGVhZC0+YnJpZGdlKSB7Cj4+IC0JCWlmICghKGhlYWQtPmJyaWRnZSA9IGFncF9i
YWNrZW5kX2FjcXVpcmUoZGV2LT5wZGV2KSkpIHsKPj4gKwkJaGVhZC0+YnJpZGdlID0gYWdwX2Jh
Y2tlbmRfYWNxdWlyZShkZXYtPnBkZXYpOwo+PiArCQlpZiAoIWhlYWQtPmJyaWRnZSkgewo+PiAg
CQkJa2ZyZWUoaGVhZCk7Cj4+ICAJCQlyZXR1cm4gTlVMTDsKPj4gIAkJfQo+PiAtLQo+PiAyLjcu
NAo+Pgo+PiAtLQo+PiBZb3UgcmVjZWl2ZWQgdGhpcyBtZXNzYWdlIGJlY2F1c2UgeW91IGFyZSBz
dWJzY3JpYmVkIHRvIHRoZSBHb29nbGUgR3JvdXBzICJvdXRyZWFjaHkta2VybmVsIiBncm91cC4K
Pj4gVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGdyb3VwIGFuZCBzdG9wIHJlY2VpdmluZyBlbWFp
bHMgZnJvbSBpdCwgc2VuZCBhbiBlbWFpbCB0byBvdXRyZWFjaHkta2VybmVsK3Vuc3Vic2NyaWJl
QGdvb2dsZWdyb3Vwcy5jb20uCj4+IFRvIHBvc3QgdG8gdGhpcyBncm91cCwgc2VuZCBlbWFpbCB0
byBvdXRyZWFjaHkta2VybmVsQGdvb2dsZWdyb3Vwcy5jb20uCj4+IFRvIHZpZXcgdGhpcyBkaXNj
dXNzaW9uIG9uIHRoZSB3ZWIgdmlzaXQgaHR0cHM6Ly9ncm91cHMuZ29vZ2xlLmNvbS9kL21zZ2lk
L291dHJlYWNoeS1rZXJuZWwvMjAxNzA5MTMxNjE1MzEuR0EzMjM5JTQwbWVnaGFuYS1IUC1QYXZp
bGlvbi1Ob3RlYm9vay4KPj4gRm9yIG1vcmUgb3B0aW9ucywgdmlzaXQgaHR0cHM6Ly9ncm91cHMu
Z29vZ2xlLmNvbS9kL29wdG91dC4KPj4KCi0tIApKYW5pIE5pa3VsYSwgSW50ZWwgT3BlbiBTb3Vy
Y2UgVGVjaG5vbG9neSBDZW50ZXIKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRl
c2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8v
ZHJpLWRldmVsCg==