From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [RFC 2/7] drm: Add GEM backed framebuffer library Date: Wed, 19 Jul 2017 13:59:34 -0700 Message-ID: <87k234dtxl.fsf@eliezer.anholt.net> References: <1499867165-60925-1-git-send-email-noralf@tronnes.org> <1499867165-60925-3-git-send-email-noralf@tronnes.org> <84ead3e1-146a-d69c-2280-061a5d36f6ba@tronnes.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0584293807==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 4CB3F6E0B6 for ; Wed, 19 Jul 2017 20:59:37 +0000 (UTC) In-Reply-To: <84ead3e1-146a-d69c-2280-061a5d36f6ba@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0584293807== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noralf Tr=C3=B8nnes writes: > Den 12.07.2017 15.46, skrev Noralf Tr=C3=B8nnes: >> Add a library for drivers that can use a simple representation >> of a GEM backed framebuffer. >> >> Signed-off-by: Noralf Tr=C3=B8nnes >> --- > > This patch adds a gem backed drm_framebuffer like this: > > struct drm_fb_gem { > /** > * @base: Base DRM framebuffer > */ > struct drm_framebuffer base; > /** > * @obj: GEM object array backing the framebuffer. One object per > * plane. > */ > struct drm_gem_object *obj[4]; > }; > > Now I wonder if it would be better to extend drm_framebuffer instead: > > struct drm_framebuffer { > + /** > + * @obj: GEM objects backing the framebuffer, one per plane (optiona= l). > + */ > + struct drm_gem_object *obj[4]; > }; FWIW, I would love to see this tried. I think we would end up with some nice cleanups if we did so. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAllvyDYACgkQtdYpNtH8 nug3BA/+Jensm/CI0iJFgQDpWz3rz+Dxw5zQQaMfvDHgDkl/1uV9TwdWkMcUQHzn GYqK64pMZcuhIkVY/sXQ/ooH5pRA7HVIvwTbT0g0KXe1U22f6erS7EoIYSkvcB9q 1H+qIJQpVWzBwmrjJvFTETWs503Cr+PXBGQKBBUPYbJR/5AK1RsZ6NAMATxg19Iz ez+J0XOKJ+3rSZ9N4rDLflXlBB+yFl07t+F3iBUYeLkSldkg8H/hFzxHAy0Ci8l9 O8Y9tQpsZGOBLaRpsECvt+0hAaJUgDy16Ukmsd/fxWRyBTpNBpok1rS5vubrxG/6 mleup4qL1vPLFXCF2ZH03U0R1SoJ6WWzJMInDyxORW0abHIdL0zxoUg2uViHqYV/ AfrpuuKEZK3XXPI/vhENj5Df0pWSVOfK9vZJizEoFJrI36IIAON4mvStnFuvZLbc QBlZkgU0gm3BOiVzIHc6TcTHhiK0FdL3WEhm17097fajfePNFIweG0gTRxX2T1YX S1Ws+vb/DhX/2mBfcnM4CNMiXIgu/nOqQI76qKDe+jPn1FxQ1RfM6eFT0plbDvTI G6r71ofZGZscktk24YbC7gKBDvmwEf/DsfYgx8S6L4RPWMI2Z2eXo1XucUgFx1FV kzECXv7mRpzmp7sj/eUlsVuXELmI4vyjvkzmO/OMjovQnF2eLyA= =5QUq -----END PGP SIGNATURE----- --=-=-=-- --===============0584293807== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0584293807==--