dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Roberts <nroberts@igalia.com>
To: Daniel Vetter <daniel@ffwll.ch>, Steven Price <steven.price@arm.com>
Cc: dri-devel <dri-devel@lists.freedesktop.org>,
	Rob Herring <robh+dt@kernel.org>,
	Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Subject: Re: [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff
Date: Tue, 23 Feb 2021 13:42:21 +0100	[thread overview]
Message-ID: <87lfbfc5w2.fsf@yahoo.co.uk> (raw)
In-Reply-To: <CAKMK7uHPk1G-S6EMRZ8grZU8W6iij_DJR+V2eBGP+79Te6k76A@mail.gmail.com>

Daniel Vetter <daniel@ffwll.ch> writes:

> Yeah plus Cc: stable for backporting and I think an igt or similar for
> panfrost to check this works correctly would be pretty good too. Since
> if it took us over 1 year to notice this bug it's pretty clear that
> normal testing doesn't catch this. So very likely we'll break this
> again.

I made the IGT test below which seems to reproduce the bug. However, the
kernel patch doesn’t fix it, so maybe there is something more subtle
going on.

https://gitlab.freedesktop.org/nroberts/igt-gpu-tools/-/commits/panfrost-purgemap/

Regards,
- Neil
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  parent reply	other threads:[~2021-02-23 12:42 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-17 16:59 [PATCH] drm/shmem-helper: Don't remove the offset in vm_area_struct pgoff Neil Roberts
2021-02-17 19:33 ` kernel test robot
2021-02-18 15:26 ` Steven Price
2021-02-18 15:30   ` Daniel Vetter
2021-02-18 15:45     ` Alyssa Rosenzweig
2021-02-18 16:15       ` Steven Price
2021-02-18 16:38         ` Rob Herring
2021-02-18 16:52           ` Steven Price
2021-02-18 17:15             ` Rob Herring
2021-02-18 18:20               ` Daniel Vetter
2021-02-19 13:36                 ` Steven Price
2021-02-19 15:13                   ` Daniel Vetter
2021-02-19 16:18                     ` Steven Price
2021-02-19 17:45                       ` Daniel Vetter
2021-02-22  8:34                         ` Boris Brezillon
2021-02-22 16:20                           ` Daniel Vetter
2021-02-23 12:42     ` Neil Roberts [this message]
2021-02-23 12:54       ` Daniel Vetter
2021-02-23 15:59         ` Neil Roberts
2021-02-23 16:40           ` Daniel Vetter
2021-02-22 14:24 ` Thomas Zimmermann
2021-02-22 16:21   ` Daniel Vetter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lfbfc5w2.fsf@yahoo.co.uk \
    --to=nroberts@igalia.com \
    --cc=alyssa.rosenzweig@collabora.com \
    --cc=daniel@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=robh+dt@kernel.org \
    --cc=steven.price@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox