From: Eric Anholt <eric@anholt.net>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org,
"Noralf Trønnes" <noralf@tronnes.org>,
sam@ravnborg.org, david@lechnology.com,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH v5 4/5] drm: Add library for shmem backed GEM objects
Date: Tue, 27 Nov 2018 12:38:44 -0800 [thread overview]
Message-ID: <87lg5es1bf.fsf@anholt.net> (raw)
In-Reply-To: <20181127085850.GX4266@phenom.ffwll.local>
[-- Attachment #1.1: Type: text/plain, Size: 993 bytes --]
Daniel Vetter <daniel@ffwll.ch> writes:
> On Mon, Nov 26, 2018 at 04:36:21PM -0800, Eric Anholt wrote:
>> Noralf Trønnes <noralf@tronnes.org> writes:
>> > +static void drm_gem_shmem_vm_close(struct vm_area_struct *vma)
>> > +{
>> > + struct drm_gem_object *obj = vma->vm_private_data;
>> > + struct drm_gem_shmem_object *shmem = to_drm_gem_shmem_obj(obj);
>> > +
>> > + drm_gem_shmem_put_pages(shmem);
>> > + drm_gem_vm_close(vma);
>> > +}
>> > +
>> > +const struct vm_operations_struct drm_gem_shmem_vm_ops = {
>> > + .fault = drm_gem_shmem_fault,
>> > + .open = drm_gem_vm_open,
>> > + .close = drm_gem_shmem_vm_close,
>> > +};
>> > +EXPORT_SYMBOL_GPL(drm_gem_shmem_vm_ops);
>>
>> I just saw a warning from drm_gem_shmem_put_pages() for
>> !shmem->pages_use_count -- I think drm_gem_vm_open() needs to
>> drm_gem_shmem_get_pages().
>
> Yeah we need a drm_gem_shmem_vm_open here.
Adding one of those fixed my refcounting issues, so I've sent out a v6
with it.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2018-11-27 20:38 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-17 13:04 [PATCH v5 0/5] drm: Add shmem GEM library Noralf Trønnes
2018-10-17 13:04 ` [PATCH v5 1/5] drm/driver: Add defaults for .gem_prime_export/import callbacks Noralf Trønnes
2018-10-17 13:04 ` [PATCH v5 2/5] drm/prime: Add drm_gem_prime_mmap() Noralf Trønnes
2018-10-17 15:22 ` Daniel Vetter
2018-10-17 13:04 ` [PATCH v5 3/5] drm/gem: Add drm_gem_object_funcs Noralf Trønnes
2018-10-22 12:57 ` Christian König
2018-10-23 13:46 ` Daniel Vetter
2018-10-31 23:37 ` Noralf Trønnes
2018-11-01 8:36 ` [Intel-gfx] " Daniel Vetter
2018-10-17 13:04 ` [PATCH v5 4/5] drm: Add library for shmem backed GEM objects Noralf Trønnes
2018-10-17 15:46 ` Daniel Vetter
2018-10-22 14:15 ` Noralf Trønnes
2018-10-23 13:50 ` Daniel Vetter
2018-11-27 0:36 ` Eric Anholt
2018-11-27 8:58 ` [Intel-gfx] " Daniel Vetter
2018-11-27 20:38 ` Eric Anholt [this message]
2018-11-28 8:22 ` Daniel Vetter
2018-11-28 21:52 ` Eric Anholt
2018-11-29 9:17 ` Daniel Vetter
2018-11-29 23:58 ` Eric Anholt
2018-12-02 15:58 ` Noralf Trønnes
2019-01-28 20:57 ` [Intel-gfx] " Rob Herring
2019-01-28 21:22 ` Noralf Trønnes
2019-01-28 22:01 ` Rob Herring
2019-01-29 0:19 ` Eric Anholt
2019-01-29 8:44 ` [Intel-gfx] " Noralf Trønnes
2018-10-17 13:04 ` [PATCH v5 5/5] drm/tinydrm: Switch from CMA to shmem buffers Noralf Trønnes
2018-10-26 22:38 ` Noralf Trønnes
2018-10-28 20:21 ` David Lechner
2018-10-28 20:46 ` Noralf Trønnes
2018-10-29 9:07 ` Daniel Vetter
2018-10-31 18:41 ` Noralf Trønnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lg5es1bf.fsf@anholt.net \
--to=eric@anholt.net \
--cc=daniel@ffwll.ch \
--cc=david@lechnology.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=noralf@tronnes.org \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox