From: Eric Anholt <eric@anholt.net>
To: Linus Walleij <linus.walleij@linaro.org>,
Gustavo Padovan <gustavo@padovan.org>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Sean Paul <seanpaul@chromium.org>,
Liviu Dudau <liviu.dudau@arm.com>
Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/pl111: Support Nomadik LCDC variant
Date: Thu, 21 Jun 2018 13:00:41 -0700 [thread overview]
Message-ID: <87lgb79afq.fsf@anholt.net> (raw)
In-Reply-To: <20180621184450.25377-1-linus.walleij@linaro.org>
[-- Attachment #1.1: Type: text/plain, Size: 650 bytes --]
Linus Walleij <linus.walleij@linaro.org> writes:
> The Nomadik has a variant of the PL110 known as "Color LCD
> Controller" LCDC. This variant has the same bit ordering as
> the DRM subsystem (in difference from the other variants)
> and adds a few bits for the control of 5551, 565 etc in the
> control register. Notably it also adds a packed RGB888
> 24BPP mode.
>
> We add support by detecting this variant and also adding a
> small plug-in that will mux the LCDC out if the ASIC happens
> to be muxed to the other graphics controller (they are
> mutually exclusive).
This all looks reasonable to me.
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2018-06-21 20:00 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-21 18:44 [PATCH] drm/pl111: Support Nomadik LCDC variant Linus Walleij
2018-06-21 20:00 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgb79afq.fsf@anholt.net \
--to=eric@anholt.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gustavo@padovan.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=liviu.dudau@arm.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=seanpaul@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox