From: Jani Nikula <jani.nikula@intel.com>
To: Martin Peres <martin.peres@linux.intel.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/2] drm: link status property and DP link training failure handling
Date: Thu, 19 Jan 2017 11:18:15 +0200 [thread overview]
Message-ID: <87lgu79zmw.fsf@intel.com> (raw)
In-Reply-To: <c84fd7f9-3b78-facb-6545-319d0250efe9@linux.intel.com>
On Wed, 18 Jan 2017, Martin Peres <martin.peres@linux.intel.com> wrote:
> On 16/12/16 15:48, Daniel Vetter wrote:
>> On Fri, Dec 16, 2016 at 12:29:05PM +0200, Jani Nikula wrote:
>>> The two remaining patches from [1], rebased.
>>>
>>> BR,
>>> Jani.
>>>
>>>
>>> [1] http://mid.mail-archive.com/1480984058-552-1-git-send-email-manasi.d.navare@intel.com
>>
>> Just for the record, I think the only thing missing here is the Xorg
>> review on the -modesetting patch. As soon as we have that I can vacuum
>> this up (probably best through drm-misc, but not sure).
>
> Hey Daniel,
>
> I tested again on Monday -modesetting with the patch from Jani to inject
> faults and did manage to get both the link-status BAD and a lower
> resolution got select dynamically when running KDE. For the latter, I
> however needed the following patch:
> https://patchwork.kernel.org/patch/9491869/
>
> Now, that being said, Jani's patch just prevents a new modeset to work,
> it does not tear down the current mode. This may be the reason why I do
> not manage to get a black screen after > 3 failures (and already a
> 1024x768 resolution).
>
> I however need to do more testing when running without a DE (straight X
> + twm and xterm). Indeed, when I hotplug my DP screen, it gets to the
> native resolution automatically without me asking for it using xrandr.
> Also, the mode that is set does not seem to go through
> intel_dp_start_link_train (what the heck?), so I do not get any failure
> and I cannot induce one :s
Huh, does your X + twm actually respond to hotplugs?
BR,
Jani.
>
> Because of this, I am a little uneasy and cannot say for sure that my
> patch for -modesetting is correct. I am hoping that Manasi will get a
> good testing rig to validate everything from end-to-end. At the very
> least, -modesetting seems to do a reasonable job.
>
> Sorry for keeping you out of the loop, but I was hoping to have a more
> clear-cut GOOD/BAD, but I seem to be mostly at a road block. Manasi told
> me it would help if I described it here, so here I am. I will continue
> assisting Manasi in her validation work!
>
> Martin
>
> PS: My kernel tree is here: https://cgit.freedesktop.org/~mperes/linux
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2017-01-19 9:18 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 10:29 [PATCH 0/2] drm: link status property and DP link training failure handling Jani Nikula
2016-12-16 10:29 ` [PATCH 1/2] drm: Add a new connector atomic property for link status Jani Nikula
2017-02-27 9:14 ` Daniel Vetter
2017-03-01 10:32 ` Daniel Vetter
2016-12-16 10:29 ` [PATCH 2/2] drm/i915: Implement Link Rate fallback on Link training failure Jani Nikula
2017-03-01 15:44 ` Daniel Vetter
2016-12-16 13:48 ` [PATCH 0/2] drm: link status property and DP link training failure handling Daniel Vetter
2016-12-16 14:47 ` Jani Nikula
2016-12-17 5:47 ` Pandiyan, Dhinakaran
2016-12-18 13:43 ` [Intel-gfx] " Daniel Vetter
2016-12-19 23:15 ` Pandiyan, Dhinakaran
2016-12-20 9:30 ` [Intel-gfx] " Daniel Vetter
2017-01-11 20:37 ` Manasi Navare
2017-01-18 21:05 ` Martin Peres
2017-01-19 9:18 ` Jani Nikula [this message]
2017-01-20 16:29 ` [Intel-gfx] " Martin Peres
2017-01-20 16:44 ` Jani Nikula
2017-01-20 17:23 ` Martin Peres
2017-01-19 11:34 ` [Intel-gfx] " Ville Syrjälä
2017-01-20 16:27 ` Martin Peres
2017-01-25 2:40 ` [Intel-gfx] " Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lgu79zmw.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=martin.peres@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).