From: Jani Nikula <jani.nikula@linux.intel.com>
To: Manasi Navare <manasi.d.navare@intel.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org
Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com>
Subject: Re: [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags
Date: Fri, 06 Mar 2020 12:30:46 +0200 [thread overview]
Message-ID: <87mu8tojvt.fsf@intel.com> (raw)
In-Reply-To: <20200306014220.20029-1-manasi.d.navare@intel.com>
On Thu, 05 Mar 2020, Manasi Navare <manasi.d.navare@intel.com> wrote:
> This patch adds defines for the detailed monitor
> range flags as per the EDID specification.
>
> Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Clinton A Taylor <clinton.a.taylor@intel.com>
> Cc: Kazlauskas Nicholas <Nicholas.Kazlauskas@amd.com>
> Signed-off-by: Manasi Navare <manasi.d.navare@intel.com>
> ---
> include/drm/drm_edid.h | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/include/drm/drm_edid.h b/include/drm/drm_edid.h
> index f0b03d401c27..f89c97623845 100644
> --- a/include/drm/drm_edid.h
> +++ b/include/drm/drm_edid.h
> @@ -91,6 +91,11 @@ struct detailed_data_string {
> u8 str[13];
> } __attribute__((packed));
>
> +#define EDID_DEFAULT_GTF_SUPPORT_FLAG 0x00
> +#define EDID_RANGE_LIMITS_ONLY_FLAG 0x01
> +#define EDID_SECONDARY_GTF_SUPPORT_FLAG 0x02
> +#define EDID_CVT_SUPPORT_FLAG 0x04
Bikeshed for consideration:
drm_edid.h has some macros with DRM_EDID_ prefix, some with EDID_
prefix, and then some with no prefix at all really. Should we start
consolidating on something when we add more?
BR,
Jani.
> +
> struct detailed_data_monitor_range {
> u8 min_vfreq;
> u8 max_vfreq;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-03-06 10:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-06 1:42 [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Manasi Navare
2020-03-06 1:42 ` [PATCH v4 2/2] drm/dp: Add function to parse EDID descriptors for adaptive sync limits Manasi Navare
2020-03-06 15:02 ` Kazlauskas, Nicholas
2020-03-06 18:52 ` [Intel-gfx] " Mario Kleiner
2020-03-06 10:30 ` Jani Nikula [this message]
2020-03-06 18:40 ` [Intel-gfx] [PATCH v4 1/2] drm/edid: Name the detailed monitor range flags Manasi Navare
2020-03-09 8:35 ` Jani Nikula
2020-03-09 20:34 ` Manasi Navare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mu8tojvt.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=Nicholas.Kazlauskas@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=manasi.d.navare@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox