From: Eric Anholt <eric@anholt.net>
To: airlie@linux.ie, daniel@ffwll.ch, dri-devel@lists.freedesktop.org
Cc: Nishka Dasgupta <nishkadg.linux@gmail.com>
Subject: Re: [PATCH] gpu: drm: pl111: pl111_vexpress.c: Add of_node_put() before return
Date: Mon, 15 Jul 2019 17:10:49 -0700 [thread overview]
Message-ID: <87muhebzzq.fsf@anholt.net> (raw)
In-Reply-To: <20190706132742.3250-1-nishkadg.linux@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 327 bytes --]
Nishka Dasgupta <nishkadg.linux@gmail.com> writes:
> Each iteration of for_each_available_child_of_node puts the previous
> node, but in the case of a break from the middle of the loop there is
> no put, thus causing a memory leak. Hence add an of_node_put before the
> break.
> Issue found with Coccinelle.
Pushed. Thanks!
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
[-- Attachment #2: Type: text/plain, Size: 159 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2019-07-16 0:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-06 13:27 [PATCH] gpu: drm: pl111: pl111_vexpress.c: Add of_node_put() before return Nishka Dasgupta
2019-07-16 0:10 ` Eric Anholt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muhebzzq.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlie@linux.ie \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=nishkadg.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox