From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 0/7] drm/vc4: Allow for more boot-time configuration Date: Mon, 04 Mar 2019 12:06:01 -0800 Message-ID: <87o96q76c6.fsf@anholt.net> References: Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2061361262==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 08C6289CD5 for ; Mon, 4 Mar 2019 20:06:04 +0000 (UTC) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Maxime Ripard , Maarten Lankhorst , Sean Paul Maxime Ripard , Daniel Vetter , David Airlie Cc: Paul Kocialkowski , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, Thomas Petazzoni , eben@raspberrypi.org List-Id: dri-devel@lists.freedesktop.org --===============2061361262== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Maxime Ripard writes: > Hi, > > The proprietary stack for the RaspberryPi allows for a number of video > parameters widely used by their users, but yet don't have any equivalents > in the mainline kernel. > > Those options are detailed here: > https://www.raspberrypi.org/documentation/configuration/config-txt/video.md > > While not all of them are desirable to have in the mainline kernel, some of > them still have value, such as properties to initialise the overscan or > rotation parameters, or the one to deal with broken displays. > > This series is an attempt to support those, and is based on a rewrite of > the command line parser I did a couple of years ago that never reached > upstream (due to a lack of time on my side). While this parser was > initially made to deal with named modes (in order to support TV modes), it > also allowed to extend it more easily, which is why it's resurrected. FWIW for other reviewers, the overscan and rotation are the really important parts of this series. Since Raspberry Pi ends up connected to TVs so frequently, there are many users of the overscan workaround. Rotation is important for supporting the official DSI touchscreen panel, which is unfortunately mounted upside down in most mounts you'll find. > Since a change of the command line parser can pretty easily get things > wrong and introduce regressions, I also worked with a number of unit tests > that you can find here: http://code.bulix.org/tpo7dg-607264?raw Would kselftests be an appropriate way to include these, maybe? --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlx9hSkACgkQtdYpNtH8 nujEoRAAgzBlFJ91r1cNmfQeAyh3Wr1d+E7t4RLkYEY5qLZCKKggQkledpFM7Z56 dlXFbouCQHgQcjBoGMYjG4tesG3kb34eYwaxs4Xzdh8s9yC1DLIkSV+i+zSc/C5b NIcg3j19QThtXH+u9hmUqT46tqZkUl9goZfM78iMaBOEhwqkj4GbDg8vNHjpnfAP ciYopnwmA7lMi8PrdAunH0kJTWrNOm4azmCzrGI2T0wMrLbZLbURAf7vZ4rcPWT3 R3mDHcjpbzByS+JjAeefrmSwJV+L9/dhwBNZqmnm5ntsFINk6Ii2HktZcAsPbrYQ j3qhiUOFwg88+SJ87pHH3S/ny01rm6XPlQtTKonbT+CsXIpMs3kxKHxH46/V2iGl Y8sMDYtNNugNUNoomJRj8KiVsWmwK0yIhPtZNRyaSj/ZRa9PvZntnzAbgZWpbAkH G9H6ee+hRvugiJdMTCwS/Kiu5cSP3hBrUUZp1Sm5FVsQR3UUjck5JEBQGL0YgOLD shCYK22hkAzQIXxs3UAw+jMfT1J9qummQe88LFYj/x1e+w22SIEf6YUmnLbY4jXu C8g4MhmMBwwuoP3HAhvNRUyZ4VuMAZEq8ZGB0OtrLgaHpr82nZ157uu8MUNPLQlg J5z1KOaESg5xGKQlB51ONd+kaLh30TkbuiCAgyH4QG/wtSqXJtI= =sTKa -----END PGP SIGNATURE----- --=-=-=-- --===============2061361262== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs --===============2061361262==--