From: Jani Nikula <jani.nikula@linux.intel.com>
To: StanLis <stanislav.lisovskiy@intel.com>, dri-devel@lists.freedesktop.org
Cc: intel-gfx@linux.intel.com
Subject: Re: [PATCH v2 1/2] drm: content-type property for HDMI connector
Date: Wed, 18 Apr 2018 14:50:11 +0300 [thread overview]
Message-ID: <87o9igwx70.fsf@intel.com> (raw)
In-Reply-To: <20180418164904.24145-2-stanislav.lisovskiy@intel.com>
On Wed, 18 Apr 2018, StanLis <stanislav.lisovskiy@intel.com> wrote:
> +static const struct drm_prop_enum_list drm_content_type_enum_list[] = {
> + { DRM_MODE_CONTENT_TYPE_GRAPHICS, "GRAPHICS" },
> + { DRM_MODE_CONTENT_TYPE_PHOTO, "PHOTO" },
> + { DRM_MODE_CONTENT_TYPE_CINEMA, "CINEMA" },
> + { DRM_MODE_CONTENT_TYPE_GAME, "GAME" },
> +};
> +
Values all caps...
> +int drm_mode_create_content_type_property(struct drm_device *dev)
> +{
> + if (dev->mode_config.content_type_property)
> + return 0;
> +
> + dev->mode_config.content_type_property =
> + drm_property_create_enum(dev, 0, "content type",
> + drm_content_type_enum_list,
> + ARRAY_SIZE(drm_content_type_enum_list));
...and property name lower case with a space.
Can we please have a little more consistency at least within properties?
Overall it's a huge mess already, but it doesn't help to add to the
mess.
BR,
Jani.
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-04-18 11:50 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 16:49 [PATCH v2 0/2] Enabling content-type setting for HDMI displays StanLis
2018-04-18 16:49 ` [PATCH v2 1/2] drm: content-type property for HDMI connector StanLis
2018-04-18 11:50 ` Jani Nikula [this message]
2018-04-18 12:06 ` Lisovskiy, Stanislav
2018-04-18 16:49 ` [PATCH v2 2/2] i915: " StanLis
-- strict thread matches above, loose matches on Subject: below --
2018-04-18 16:51 [PATCH v2 0/2] Enabling content-type setting for HDMI displays StanLis
2018-04-18 16:51 ` [PATCH v2 1/2] drm: content-type property for HDMI connector StanLis
2018-04-18 11:36 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9igwx70.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@linux.intel.com \
--cc=stanislav.lisovskiy@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox