From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jani Nikula <jani.nikula@linux.intel.com>
Subject: Re: drivers/gpu/drm/gma500/mdfld_intel_display.c:102:37: warning: bitwise comparison always evaluates to false [-Wtautological-compare]
Date: Tue, 24 Oct 2017 11:54:05 +0300
Message-ID: <87po9dhqoi.fsf@intel.com>
References: <VI1PR0802MB2336FE2CC4B113AD21AAB1CD9C460@VI1PR0802MB2336.eurprd08.prod.outlook.com>
Mime-Version: 1.0
Content-Type: text/plain
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <VI1PR0802MB2336FE2CC4B113AD21AAB1CD9C460@VI1PR0802MB2336.eurprd08.prod.outlook.com>
Sender: linux-kernel-owner@vger.kernel.org
To: David Binderman <dcb314@hotmail.com>, "patrik.r.jakobsson@gmail.com" <patrik.r.jakobsson@gmail.com>, "airlied@linux.ie" <airlied@linux.ie>, "dri-devel@lists.freedesktop.org" <dri-devel@lists.freedesktop.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
List-Id: dri-devel@lists.freedesktop.org

On Mon, 23 Oct 2017, David Binderman <dcb314@hotmail.com> wrote:
> Hello there,
>
> Source code is
>
>         if ((temp & PIPEACONF_PIPE_STATE) == 1)
>             break;
>
> but
>
> $ fgrep PIPEACONF_PIPE_STATE `find drivers/gpu/drm/gma500 -name \*.h -print`
> drivers/gpu/drm/gma500/psb_intel_reg.h:#define PIPEACONF_PIPE_STATE		(1 << 30)
> $ 
>
> Suggest new code
>
>         if ((temp & PIPEACONF_PIPE_STATE) != 0)
>             break;

Suggest looking at latest sources. ;)

Fixed by 67a3b63a54cb ("drm: gma500: fix logic error").

BR,
Jani.

-- 
Jani Nikula, Intel Open Source Technology Center