From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Anholt Subject: Re: [PATCH 02/41] drm/dumb-buffers: Add defaults for .dumb_map_offset and .dumb_destroy Date: Mon, 24 Jul 2017 09:33:39 -0700 Message-ID: <87pocpbxr0.fsf@eliezer.anholt.net> References: <1500837417-40580-1-git-send-email-noralf@tronnes.org> <1500837417-40580-3-git-send-email-noralf@tronnes.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0818804696==" Return-path: Received: from anholt.net (anholt.net [50.246.234.109]) by gabe.freedesktop.org (Postfix) with ESMTP id 37E3C6E310 for ; Mon, 24 Jul 2017 16:33:42 +0000 (UTC) In-Reply-To: <1500837417-40580-3-git-send-email-noralf@tronnes.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Noralf =?utf-8?Q?Tr=C3=B8nnes?= , dri-devel@lists.freedesktop.org Cc: narmstrong@baylibre.com, liviu.dudau@arm.com, linux@armlinux.org.uk, thierry.reding@gmail.com, laurent.pinchart@ideasonboard.com, daniel.vetter@intel.com, marex@denx.de, boris.brezillon@free-electrons.com, abrodkin@synopsys.com, z.liuxinliang@hisilicon.com, kong.kongxinwei@hisilicon.com, tomi.valkeinen@ti.com, bskeggs@redhat.com, airlied@redhat.com, puck.chen@hisilicon.com, zourongrong@gmail.com, jsarha@ti.com, vincent.abriou@st.com, alison.wang@freescale.com, sw0312.kim@samsung.com, philippe.cornu@st.com, yannick.fertre@st.com, kyungmin.park@samsung.com, alexander.deucher@amd.com, maxime.ripard@free-electrons.com, shawnguo@kernel.org, christian.koenig@amd.com, kraxel@redhat.com List-Id: dri-devel@lists.freedesktop.org --===============0818804696== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Noralf Tr=C3=B8nnes writes: > Almost everyone did end up using GEM as bo, so this adds defaults > for the drm_driver.dumb_destroy and drm_driver.dumb_map_offset > callbacks. > > Signed-off-by: Noralf Tr=C3=B8nnes > --- > drivers/gpu/drm/drm_dumb_buffers.c | 26 ++++++++++++++++++-------- > 1 file changed, 18 insertions(+), 8 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dumb_buffers.c b/drivers/gpu/drm/drm_dum= b_buffers.c > index 10307cc..cd68ab4 100644 > --- a/drivers/gpu/drm/drm_dumb_buffers.c > +++ b/drivers/gpu/drm/drm_dumb_buffers.c > @@ -24,6 +24,7 @@ > */ >=20=20 > #include > +#include >=20=20 > #include "drm_crtc_internal.h" >=20=20 > @@ -42,9 +43,10 @@ > * create dumb buffers suitable for scanout, which can then be used to c= reate > * KMS frame buffers. > * > - * To support dumb objects drivers must implement the &drm_driver.dumb_c= reate, > - * &drm_driver.dumb_destroy and &drm_driver.dumb_map_offset operations. = See > - * there for further details. > + * To support dumb objects drivers must implement the &drm_driver.dumb_c= reate > + * operation. &drm_driver.dumb_destroy defaults to drm_gem_dumb_destroy(= ) if > + * not set and &drm_driver.dumb_map_offset operations to s/operations/default/ I think Other than that, patch 1-2 are: Reviewed-by: Eric Anholt Thanks for working on these cleanups! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAll2IWMACgkQtdYpNtH8 nugVsg//aNuYyNehGvvSmI4UPDAFdDFobESXMcJlhjqILKz9Oj/cQw/QS/+lJq/6 L3CYjE/Besyq0UhC8QN//3w4nQtyf9q/RvAV0VPgoXf82Wmo20N7myQNdDx4S++L oJr16odv5Vm3J7TzBxO1ofGsBkxWKW+KkOvpUeDF+dwZpTKJPX90l7MWThZc4jQ7 fU/6e6l9fNcdPhmeqM9ulpFnNPA/yv66cMUOF0ffhvnyG5FMK6nHhbsdKE8iKGT9 NQSOfl9v+A1BeiXRvCGEZ1yJz/uYL32XmFlM/8QkPkUWnufRwwhds7pXLgr0oF8x cBokUtohxX+mei5QjTHVZ8AAMKOQN89hnnsDOdCy/57VsbXBz924pRjYwD8ZgZ2n M027BmzKmtvk4m+S9cYRXcQ9k4z0ThCapVsKbmUPy62/MlhUO6Txe3F+kMtmA3MD ewesTicU4jqrMbwLU4inddn+AQR0475RzWiFPyUrZhhyHHCMJKSQiU9HtVMi2QdB ZEFTtuD2A/KuAmunQF+dQCdQtEno1LXuqxu1/vr0GN13NsYPeAaLlP1KlAHJxNSV K1b4CLQ+p8AxFLHDkSgTiPH0gqid9KRWKu17vw3UqpR8jlzGYjgp1KKK2yHJ8+Zk yZ0eix9/aZRrWZaA7X4Q7Prru5jFm0EO0Eydx8RVJvvabjypMj4= =5EWa -----END PGP SIGNATURE----- --=-=-=-- --===============0818804696== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0818804696==--