From: Jani Nikula <jani.nikula@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/mm: annotate drm_mm_node_scanned_block() with __maybe_unused
Date: Wed, 04 Sep 2024 12:18:57 +0300 [thread overview]
Message-ID: <87r09zsrni.fsf@intel.com> (raw)
In-Reply-To: <ZtdUcteHkNDNbZAw@smile.fi.intel.com>
On Tue, 03 Sep 2024, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Tue, Sep 03, 2024 at 08:34:37PM +0300, Jani Nikula wrote:
>> Clang build with CONFIG_DRM_DEBUG_MM=n, CONFIG_WERROR=y, and W=1 leads
>> to:
>>
>> CC [M] drivers/gpu/drm/drm_mm.o
>> ../drivers/gpu/drm/drm_mm.c:614:20: error: function 'drm_mm_node_scanned_block' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
>> static inline bool drm_mm_node_scanned_block(const struct drm_mm_node *node)
>> ^
>>
>> Fix this by annotating drm_mm_node_scanned_block() with __maybe_unused.
>
> FWIW,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Pushed to drm-misc-next, thanks for the review.
BR,
Jani.
--
Jani Nikula, Intel
prev parent reply other threads:[~2024-09-04 9:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-03 17:34 [PATCH] drm/mm: annotate drm_mm_node_scanned_block() with __maybe_unused Jani Nikula
2024-09-03 18:24 ` Andy Shevchenko
2024-09-04 9:18 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r09zsrni.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).