From: Jani Nikula <jani.nikula@linux.intel.com>
To: "Noralf Trønnes" <noralf@tronnes.org>,
dri-devel <dri-devel@lists.freedesktop.org>
Cc: Randy Dunlap <rdunlap@infradead.org>
Subject: Re: simpledrm problem: Kconfig:error: recursive dependency detected!
Date: Thu, 04 Aug 2016 10:04:26 +0300 [thread overview]
Message-ID: <87r3a5ow05.fsf@intel.com> (raw)
In-Reply-To: <fac78a58-20e9-e12a-3474-50b619e0c8e7@tronnes.org>
On Wed, 03 Aug 2016, Noralf Trønnes <noralf@tronnes.org> wrote:
> Hi,
>
> I have changed simpledrm to use drm_simple_kms_helper and now I'm
> facing this:
>
> drivers/video/fbdev/Kconfig:5:error: recursive dependency detected!
> For a resolution refer to Documentation/kbuild/kconfig-language.txt
>
> drivers/video/fbdev/Kconfig:5: symbol FB is selected by DRM_KMS_FB_HELPER
>
> drivers/gpu/drm/Kconfig:42: symbol DRM_KMS_FB_HELPER depends on
> DRM_KMS_HELPER
>
> drivers/gpu/drm/Kconfig:36: symbol DRM_KMS_HELPER is selected by
> DRM_SIMPLEDRM
>
> drivers/gpu/drm/simpledrm/Kconfig:1: symbol DRM_SIMPLEDRM depends on
> FB_SIMPLE
>
> drivers/video/fbdev/Kconfig:2428: symbol FB_SIMPLE depends on FB
>
>
> Using this Kconfig:
>
> config DRM_SIMPLEDRM
> tristate "Simple firmware framebuffer DRM driver"
> depends on DRM && (FB_SIMPLE = n)
> select DRM_KMS_HELPER
>
>
> Is there a solution to this apart from depending on DRM_KMS_HELPER or
> removing the FB_SIMPLE dependency?
I think the underlying problem is the overuse of "select" all around. I
think people use it for convenience because unsatisfied "depends" hides
a menu option in menuconfig while "select" does not, and it's sometimes
hard to find all the dependencies of an option just to *show* it in
menuconfig.
I don't know what the exact cause here is, but having hunted these down
before, it's often a rabbit hole where you end up having to change a ton
of config options to make it robust, and those changes get rejected
because the menuconfig convenience is lost, and I've given up. :/
Would be great to have a menuconfig feature to recursively enable and
option and all dependencies. Perhaps we could then be more strict about
using "select" for stuff with dependencies.
BR,
Jani.
> video/ is before gpu/ in drivers/Makefile, so having both simpledrm and
> simplefb selected, I guess simplefb will be the one that's used?
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-08-04 7:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 18:48 simpledrm problem: Kconfig:error: recursive dependency detected! Noralf Trønnes
2016-08-04 7:04 ` Jani Nikula [this message]
2016-08-04 7:07 ` David Herrmann
2016-08-04 7:48 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r3a5ow05.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=noralf@tronnes.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox