From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CCD90C369C2 for ; Fri, 25 Apr 2025 08:48:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E42BC10E8D2; Fri, 25 Apr 2025 08:48:43 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=intel.com header.i=@intel.com header.b="HGtzMlES"; dkim-atps=neutral Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0ED1410E8D1; Fri, 25 Apr 2025 08:48:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1745570922; x=1777106922; h=from:to:cc:subject:in-reply-to:references:date: message-id:mime-version; bh=Z6Vt1Z3I1guU2hYZHvh38GC960N/SVGBXhEuV6XKHd8=; b=HGtzMlES7d5tFzWtLJnN5Wunrq2q7xQMa4EMJexVJLU6T8+LGMkLtO/4 vcHHMzpRpuLr+85GyV0/7BLSuplsmM6Rd4hSfLBerT2DhFEpjUq45alIn CptVgHjF0hNmKJ4AFwnSyENnoGhFx97Q5W4atwrMlvd7YDc/wqf/9CadL j6teJyHhc1q3VWutm9L6uqdjAQzVBHHmly2l27VWBHXynM5iAMkkftxhZ cwfQSJRcyPheXXwPrYyusJ2j9snOd54k+6meFwX+596hSUaepzW5AkLP+ XzI6CyhfrDEiiF/ZYsMEgG8IuFIc8ONavzJ6y2LW1p1uaXcLGlerCdE3h w==; X-CSE-ConnectionGUID: BuBavXynQHOAsHJgjcT8TQ== X-CSE-MsgGUID: +CrutbDHQjCTlf4Fx5hqwA== X-IronPort-AV: E=McAfee;i="6700,10204,11413"; a="51047838" X-IronPort-AV: E=Sophos;i="6.15,238,1739865600"; d="scan'208";a="51047838" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2025 01:48:42 -0700 X-CSE-ConnectionGUID: vre/oGHZT5aTBp+dRxeO/Q== X-CSE-MsgGUID: ZPjFH3Z0Tne3nrt8JpseLw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.15,238,1739865600"; d="scan'208";a="132741259" Received: from kniemiec-mobl1.ger.corp.intel.com (HELO localhost) ([10.245.246.83]) by fmviesa006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Apr 2025 01:48:35 -0700 From: Jani Nikula To: "Paul E. McKenney" , linux-kernel@vger.kernel.org Cc: kernel-team@meta.com, Andrew Morton , Kuniyuki Iwashima , Mateusz Guzik , Petr Mladek , Steven Rostedt , John Ogness , Sergey Senozhatsky , Jon Pan-Doh , Bjorn Helgaas , Karolina Stolarek , "Paul E. McKenney" , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v3 04/20] drm/i915: Avoid open-coded use of ratelimit_state structure's ->missed field In-Reply-To: <20250425002826.3431914-4-paulmck@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo References: <72ee57b8-9e2a-4cad-aaa0-1e3353d146d8@paulmck-laptop> <20250425002826.3431914-4-paulmck@kernel.org> Date: Fri, 25 Apr 2025 11:48:31 +0300 Message-ID: <87selwy6cg.fsf@intel.com> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, 24 Apr 2025, "Paul E. McKenney" wrote: > The i915_oa_stream_destroy() function directly accesses the > ratelimit_state structure's ->missed field, which work, but which also > makes it more difficult to change this field. Therefore, make use of > the ratelimit_state_get_miss() function instead of directly accessing > the ->missed field. Acked-by: Jani Nikula For merging via whichever tree is convenient for you. Please let us know if you want us to pick it up via drm-intel. > > Link: https://lore.kernel.org/all/fbe93a52-365e-47fe-93a4-44a44547d601@paulmck-laptop/ > Link: https://lore.kernel.org/all/20250423115409.3425-1-spasswolf@web.de/ > Signed-off-by: Paul E. McKenney > Reviewed-by: Petr Mladek > Cc: Jani Nikula > Cc: Joonas Lahtinen > Cc: Rodrigo Vivi > Cc: Tvrtko Ursulin > Cc: David Airlie > Cc: Simona Vetter > Cc: > Cc: > --- > drivers/gpu/drm/i915/i915_perf.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c > index de0b413600a15..1658f1246c6fa 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -1666,6 +1666,7 @@ static void i915_oa_stream_destroy(struct i915_perf_stream *stream) > struct i915_perf *perf = stream->perf; > struct intel_gt *gt = stream->engine->gt; > struct i915_perf_group *g = stream->engine->oa_group; > + int m; > > if (WARN_ON(stream != g->exclusive_stream)) > return; > @@ -1690,10 +1691,9 @@ static void i915_oa_stream_destroy(struct i915_perf_stream *stream) > free_oa_configs(stream); > free_noa_wait(stream); > > - if (perf->spurious_report_rs.missed) { > - gt_notice(gt, "%d spurious OA report notices suppressed due to ratelimiting\n", > - perf->spurious_report_rs.missed); > - } > + m = ratelimit_state_get_miss(&perf->spurious_report_rs); > + if (m) > + gt_notice(gt, "%d spurious OA report notices suppressed due to ratelimiting\n", m); > } > > static void gen7_init_oa_buffer(struct i915_perf_stream *stream) -- Jani Nikula, Intel