Re: [PATCH] drm/i915: Remove unused for_each_uabi_class_engine

[Jani Nikula <jani.nikula@linux.intel.com>]

On Wed, 01 Nov 2023, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Unused macro after 99919be74aa3 ("drm/i915/gem: Zap the i915_gem_object_blt code")
> removed some code.
>
> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>

\o/

Reviewed-by: Jani Nikula <jani.nikula@intel.com>

Could I persuade you to move for_each_engine(),
for_each_engine_masked(), rb_to_uabi_engine(), and
for_each_uabi_engine() to a more suitable header?

> ---
>  drivers/gpu/drm/i915/i915_drv.h | 5 -----
>  1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
> index bfcbe93bd9fe..744c8c4a50fa 100644
> --- a/drivers/gpu/drm/i915/i915_drv.h
> +++ b/drivers/gpu/drm/i915/i915_drv.h
> @@ -418,11 +418,6 @@ static inline struct intel_gt *to_gt(const struct drm_i915_private *i915)
>  	     (engine__); \
>  	     (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
>  
> -#define for_each_uabi_class_engine(engine__, class__, i915__) \
> -	for ((engine__) = intel_engine_lookup_user((i915__), (class__), 0); \
> -	     (engine__) && (engine__)->uabi_class == (class__); \
> -	     (engine__) = rb_to_uabi_engine(rb_next(&(engine__)->uabi_node)))
> -
>  #define INTEL_INFO(i915)	((i915)->__info)
>  #define RUNTIME_INFO(i915)	(&(i915)->__runtime)
>  #define DRIVER_CAPS(i915)	(&(i915)->caps)

-- 
Jani Nikula, Intel