Re: [PATCH libdrm] meson: add configuration summary

[Eric Anholt <eric@anholt.net>]

[-- Attachment #1.1: Type: text/plain, Size: 1764 bytes --]

Dylan Baker <dylan@pnwbakers.com> writes:

> [ Unknown signature status ]
> Quoting Eric Engestrom (2018-02-27 03:11:07)
>> The message block printed is the same as the one in configure.ac
>> 
>> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
>> ---
>>  meson.build | 17 +++++++++++++++++
>>  1 file changed, 17 insertions(+)
>> 
>> diff --git a/meson.build b/meson.build
>> index bd00cdc2cae9f0749180..ab6f881755935968b822 100644
>> --- a/meson.build
>> +++ b/meson.build
>> @@ -373,3 +373,20 @@ if with_man_pages
>>  endif
>>  subdir('data')
>>  subdir('tests')
>> +
>> +message('')
>> +message('@0@ will be compiled with:'.format(meson.project_name()))
>> +message('')
>> +message('  libkms         @0@'.format(with_libkms))
>> +message('  Intel API      @0@'.format(with_intel))
>> +message('  vmwgfx API     @0@'.format(with_vmwgfx))
>> +message('  Radeon API     @0@'.format(with_radeon))
>> +message('  AMDGPU API     @0@'.format(with_amdgpu))
>> +message('  Nouveau API    @0@'.format(with_nouveau))
>> +message('  OMAP API       @0@'.format(with_omap))
>> +message('  EXYNOS API     @0@'.format(with_exynos))
>> +message('  Freedreno API  @0@ (kgsl: @1@)'.format(with_freedreno, with_freedreno_kgsl))
>> +message('  Tegra API      @0@'.format(with_tegra))
>> +message('  VC4 API        @0@'.format(with_vc4))
>> +message('  Etnaviv API    @0@'.format(with_etnaviv))
>> +message('')
>> -- 
>> Cheers,
>>   Eric
>> 
>
> This one is certainly simple enough that we can use a single message call and a
> ''' string :)

But then you end up with 13 @n@ values and when someone wants to put
something earlier in the list for some sorting reason, then they need to
renumber the rest.  This is much nicer.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel