From: Jani Nikula <jani.nikula@intel.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/edid: constify edid quirk list
Date: Mon, 02 Jan 2017 15:24:14 +0200 [thread overview]
Message-ID: <87shp1ioht.fsf@intel.com> (raw)
In-Reply-To: <20161228130746.GN347@dvetter-linux.ger.corp.intel.com>
On Wed, 28 Dec 2016, Daniel Vetter <daniel@ffwll.ch> wrote:
> On Wed, Dec 28, 2016 at 01:06:26PM +0200, Jani Nikula wrote:
>> No reason not to be const.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>
> Reviewed-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Pushed, thanks for the review.
BR,
Jani.
>
>> ---
>> drivers/gpu/drm/drm_edid.c | 6 +++---
>> 1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
>> index 67d6a73731d8..4ff04aa84dd0 100644
>> --- a/drivers/gpu/drm/drm_edid.c
>> +++ b/drivers/gpu/drm/drm_edid.c
>> @@ -91,7 +91,7 @@ struct detailed_mode_closure {
>> #define LEVEL_GTF2 2
>> #define LEVEL_CVT 3
>>
>> -static struct edid_quirk {
>> +static const struct edid_quirk {
>> char vendor[4];
>> int product_id;
>> u32 quirks;
>> @@ -1478,7 +1478,7 @@ EXPORT_SYMBOL(drm_edid_duplicate);
>> *
>> * Returns true if @vendor is in @edid, false otherwise
>> */
>> -static bool edid_vendor(struct edid *edid, char *vendor)
>> +static bool edid_vendor(struct edid *edid, const char *vendor)
>> {
>> char edid_vendor[3];
>>
>> @@ -1498,7 +1498,7 @@ static bool edid_vendor(struct edid *edid, char *vendor)
>> */
>> static u32 edid_get_quirks(struct edid *edid)
>> {
>> - struct edid_quirk *quirk;
>> + const struct edid_quirk *quirk;
>> int i;
>>
>> for (i = 0; i < ARRAY_SIZE(edid_quirk_list); i++) {
>> --
>> 2.1.4
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Jani Nikula, Intel Open Source Technology Center
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
prev parent reply other threads:[~2017-01-02 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 11:06 [PATCH] drm/edid: constify edid quirk list Jani Nikula
2016-12-28 13:07 ` Daniel Vetter
2017-01-02 13:24 ` Jani Nikula [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87shp1ioht.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox