From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Anholt <eric@anholt.net>
Subject: Re: [PATCH 2/2] drm/vc4: Set ->legacy_cursor_update to false when doing non-async updates
Date: Tue, 13 Nov 2018 13:18:35 -0800
Message-ID: <87tvkkllqs.fsf@anholt.net>
References: <20181113094914.22353-1-boris.brezillon@bootlin.com> <20181113094914.22353-2-boris.brezillon@bootlin.com>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha512; protocol="application/pgp-signature"
Return-path: <stable-owner@vger.kernel.org>
In-Reply-To: <20181113094914.22353-2-boris.brezillon@bootlin.com>
Sender: stable-owner@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org, Boris Brezillon <boris.brezillon@bootlin.com>, stable@vger.kernel.org
List-Id: dri-devel@lists.freedesktop.org

--=-=-=
Content-Type: text/plain

Boris Brezillon <boris.brezillon@bootlin.com> writes:

> drm_atomic_helper_setup_commit() auto-completes commit->flip_done when
> state->legacy_cursor_update is true, but we now for sure that we want
> a sync update when we call drm_atomic_helper_setup_commit() from
> vc4_atomic_commit().
>
> Explicitly set state->legacy_cursor_update to false to prevent this
> auto-completion.

Seems like a reasonable solution.

Reviewed-by: Eric Anholt <eric@anholt.net>

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEE/JuuFDWp9/ZkuCBXtdYpNtH8nugFAlvrP6sACgkQtdYpNtH8
nujyqw/8CHP8KNBSHqdqPJ7UGvuMfWD1QzuWbHDVeGScKmDePd0tolx5uQ8baoD1
s84qv2fjH4h2pTJA0+rRDWAjvB7EpSQ2NGZ6RQ93L8psS7Nm1TpVCXmwZCVooVrg
ENkkyEkq2VvXznCTrW9k3am6EmK2uDu2VKi9WbMwr34AtHaFskClOK02NeqY5BFy
3GaM7icFhgIl4Zlm8esO5wFY9jz5Qr3k7xoR7PNNQmph6CsFPORtPAprJ3W0b6C6
Moq6kv1WvK6dsicLOn2ZCsW7brc/E3FDH/G3D03lL/9K5/9IoQT3/fVHypBPcFPO
MdvVG8CEK3kzCm3DWi+xe6KRVKYzg0EVMj7Qffk6ieWVmuQO19k05U7hCebUNFdB
33kZURlO+kN1ktBGjo8a+YfUoKFzSnzR4udwGng7wc09Zx+DrcNrS1wo/nLb22oo
cRvtR+QHC3KVjvVPhLP48tEvV9JU5ftkJ1qtGUxwRtLQ73M/s70QOplMimmWBdMS
U+PrGXDxVgwhAiTj82Zqpx1WHk4Mwhph2k5sCBShcLrUiJQVxYDi8L6LTiSFAppb
XgqUzUnmA4peUEaETrAp/Hp2VwOmp6rWi3E6f/YkqvQsRou03wijPzkCz+/M3b0d
Jnu2MCaLsL0h6zM30dY7krQIu2fVA1h2+FCeDjulECjhLEtJFMw=
=D94S
-----END PGP SIGNATURE-----
--=-=-=--