From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jani Nikula Subject: Re: [PATCH 1/5] drm: Add atomic helper to redo a modeset on current mode Date: Tue, 25 Oct 2016 15:09:39 +0300 Message-ID: <87twc0mxz0.fsf@intel.com> References: <1477093543-11622-1-git-send-email-manasi.d.navare@intel.com> <1477093543-11622-2-git-send-email-manasi.d.navare@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1477093543-11622-2-git-send-email-manasi.d.navare@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Manasi Navare , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gU2F0LCAyMiBPY3QgMjAxNiwgTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVs LmNvbT4gd3JvdGU6Cj4gVGhpcyBmdW5jdGlvbiBwcm92aWRlcyBhIHdheSBmb3IgdGhlIGRyaXZl ciB0byByZWRvIGEKPiBtb2Rlc2V0IG9uIHRoZSBjdXJyZW50IG1vZGUgYW5kIHJldHJ5IHRoZSBs aW5rIHRyYWluaW5nCj4gYXQgYSBsb3dlciBsaW5rIHJhdGUvbGFuZSBjb3VudC9icHAuIFRoaXMg d2lsbCBnZXQgY2FsbGVkCj4gaW5jYXNlIHRoZSBsaW5rIHRyYWluaW5nIGZhaWxzIGR1cmluZyB0 aGUgY3VycmVudCBtb2Rlc2V0LgoKQmFzZWQgb24gZGlzY3Vzc2lvbnMgb24gI2ludGVsLWdmeCwg SSB3b3VsZCBkb2RnZSBhbGwgdGhlIHByb2JsZW1zIGhlcmUKYnkgaGF2aW5nIHRoZSB1c2Vyc3Bh Y2UgZG8gdGhlIG1vZGVzZXQuCgpJZiB3ZSBhZGQgYSBjb25uZWN0b3IgcHJvcGVydHkgdG8gaW5k aWNhdGUgdGhlIGxpbmsgc3RhdHVzIChhbmQgdGhpcwpkb2VzIG5vdCBoYXZlIHRvIGJlIERQIG9y IGxpbmsgdHJhaW5pbmcgc3BlY2lmaWMsIHJlYWxseSksIHdlIGNhbiBzZXQKdGhhdCB0byAiYmFk IiwgYW5kIGZpcmUgb2ZmIHRoZSBob3RwbHVnIHVldmVudC4gVGhlbiB1c2Vyc3BhY2UgaGFzIHRo ZQppbmZvcm1hdGlvbiB0byBmb3JjZSBhIG1vZGVzZXQgb24gdGhhdCBjb25uZWN0b3IgZXZlbiBp ZiB0aGUgbW9kZSBoYXMKbm90IGNoYW5nZWQuIChDcmVkaXRzIHRvIFZpbGxlIGZvciB0aGUgaWRl YS4pCgpJZiB3ZSBmaW5kIGEgc29sdXRpb24gbGF0ZXIgb24gdGhhdCBhbGxvd3MgdXMgdG8gaGFu ZGxlIGFsbCBvZiB0aGlzIGluCmtlcm5lbCwgd2UgY2FuIGRvIHNvLCBhbmQgcmVtb3ZlIHRoZSBw cm9wZXJ0eSBvciBhbHdheXMgcmVwb3J0CiJnb29kIi4gRHJpdmVycyBjYW4gY2hvb3NlIGRpZmZl cmVudCBhcHByb2FjaGVzLCBkZXBlbmRpbmcgb24gdGhlCmNhcGFiaWxpdGllcyBvZiB0aGUgaGFy ZHdhcmUsIGZvciBpbnN0YW5jZS4KCkRlZmVycmluZyB0aGlzIHRvIHRoZSB1c2Vyc3BhY2UgZG9l cyBub3QgcmVncmVzcyBhbnl0aGluZyBub3csIGJlY2F1c2UKY3VycmVudGx5IHdlIGp1c3QgY29t cGxldGVseSBmYWlsIGFuZCBlbmQgdXAgd2l0aCBhIGJsYWNrIHNjcmVlbi4gVGhlCnByb3BlcnR5 IHdvdWxkIGFsbG93IGFuIGVubGlnaHRlbmVkIHVzZXJzcGFjZSB0byBmaXggdGhhdC4gQW5kIHVz ZXJzcGFjZQpjYW4ndCByZWx5IG9uIHRoZSBwcm9wZXJ0eSBiZWluZyB0aGVyZSwgYXMgaXQncyBj dXJyZW50bHkgbm90IHRoZXJlLgoKCkJSLApKYW5pLgoKCj4KPiBDYzogZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwo+IENjOiBKYW5pIE5pa3VsYSA8amFuaS5uaWt1bGFAbGludXguaW50 ZWwuY29tPgo+IENjOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGludGVsLmNvbT4KPiBD YzogVmlsbGUgU3lyamFsYSA8dmlsbGUuc3lyamFsYUBsaW51eC5pbnRlbC5jb20+Cj4gU2lnbmVk LW9mZi1ieTogTWFuYXNpIE5hdmFyZSA8bWFuYXNpLmQubmF2YXJlQGludGVsLmNvbT4KPiAtLS0K PiAgZHJpdmVycy9ncHUvZHJtL2RybV9hdG9taWNfaGVscGVyLmMgfCA1OCArKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrCj4gIGluY2x1ZGUvZHJtL2RybV9hdG9taWNfaGVscGVy LmggICAgIHwgIDEgKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDU5IGluc2VydGlvbnMoKykKPgo+IGRp ZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYyBiL2RyaXZlcnMv Z3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gaW5kZXggZjkzNjI3Ni4uMGMxNjE0ZSAxMDA2 NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJtX2F0b21pY19oZWxwZXIuYwo+ICsrKyBiL2Ry aXZlcnMvZ3B1L2RybS9kcm1fYXRvbWljX2hlbHBlci5jCj4gQEAgLTI4OTUsNiArMjg5NSw2NCBA QCBpbnQgZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX2RwbXMoc3RydWN0IGRybV9jb25uZWN0 b3IgKmNvbm5lY3RvciwKPiAgRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0 b3JfZHBtcyk7Cj4gIAo+ICAvKioKPiArICogZHJtX2F0b21pY19oZWxwZXJfY29ubmVjdG9yX21v ZGVzZXQgLSBGb3JjZSBhIG1vZGVzZXQgb24gYSBjb25uZWN0b3IKPiArICogQGNvbm5lY3Rvcjog RFJNIGNvbm5lY3Rvcgo+ICsgKgo+ICsgKiBQcm92aWRlcyBhIHdheSB0byByZWRvIGEgbW9kZXNl dCB3aXRoIHRoZSBjdXJyZW50IG1vZGUgc28gdGhhdCBpdCBjYW4KPiArICogZHJvcCB0aGUgYnBw LCBsaW5rIHJhdGUvbGFuZSBjb3VudCBhbmQgcmV0cnkgdGhlIGxpbmsgdHJhaW5pbmcuCj4gKyAq Cj4gKyAqIFJldHVybnM6Cj4gKyAqIFJldHVybnMgMCBvbiBzdWNjZXNzLCBuZWdhdGl2ZSBlcnJu byBudW1iZXJzIG9uIGZhaWx1cmUuCj4gKyAqLwo+ICtpbnQKPiArZHJtX2F0b21pY19oZWxwZXJf Y29ubmVjdG9yX21vZGVzZXQoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5lY3RvcikKPiArewo+ ICsJc3RydWN0IGRybV9kZXZpY2UgKmRldiA9IGNvbm5lY3Rvci0+ZGV2Owo+ICsJc3RydWN0IGRy bV9tb2Rlc2V0X2FjcXVpcmVfY3R4IGN0eDsKPiArCXN0cnVjdCBkcm1fYXRvbWljX3N0YXRlICpz dGF0ZTsKPiArCXN0cnVjdCBkcm1fY29ubmVjdG9yX3N0YXRlICpjb25uZWN0b3Jfc3RhdGU7Cj4g KwlzdHJ1Y3QgZHJtX2NydGNfc3RhdGUgKmNydGNfc3RhdGU7Cj4gKwlpbnQgcmV0ID0gMDsKPiAr Cj4gKwlkcm1fbW9kZXNldF9hY3F1aXJlX2luaXQoJmN0eCwgMCk7Cj4gKwlzdGF0ZSA9IGRybV9h dG9taWNfc3RhdGVfYWxsb2MoZGV2KTsKPiArCWlmICghc3RhdGUpIHsKPiArCQlyZXQgPSAtRU5P TUVNOwo+ICsJCWdvdG8gZmFpbDsKPiArCX0KPiArCXN0YXRlLT5hY3F1aXJlX2N0eCA9ICZjdHg7 Cj4gK3JldHJ5Ogo+ICsJcmV0ID0gMDsKPiArCWNvbm5lY3Rvcl9zdGF0ZSA9IGRybV9hdG9taWNf Z2V0X2Nvbm5lY3Rvcl9zdGF0ZShzdGF0ZSwgY29ubmVjdG9yKTsKPiArCWlmIChJU19FUlIoY29u bmVjdG9yX3N0YXRlKSkgewo+ICsJCXJldCA9IFBUUl9FUlIoY29ubmVjdG9yX3N0YXRlKTsKPiAr CQlnb3RvIGZhaWw7Cj4gKwl9Cj4gKwlpZiAoIWNvbm5lY3Rvcl9zdGF0ZS0+Y3J0YykKPiArCQln b3RvIGZhaWw7Cj4gKwo+ICsJY3J0Y19zdGF0ZSA9IGRybV9hdG9taWNfZ2V0X2V4aXN0aW5nX2Ny dGNfc3RhdGUoc3RhdGUsCj4gKwkJCQkJCQljb25uZWN0b3Jfc3RhdGUtPmNydGMpOwo+ICsJY3J0 Y19zdGF0ZS0+Y29ubmVjdG9yc19jaGFuZ2VkID0gdHJ1ZTsKPiArCXJldCA9IGRybV9hdG9taWNf Y29tbWl0KHN0YXRlKTsKPiArZmFpbDoKPiArCWlmIChyZXQgPT0gLUVERUFETEspIHsKPiArCQlk cm1fYXRvbWljX3N0YXRlX2NsZWFyKHN0YXRlKTsKPiArCQlkcm1fbW9kZXNldF9iYWNrb2ZmKCZj dHgpOwo+ICsJCWdvdG8gcmV0cnk7Cj4gKwl9Cj4gKwo+ICsJaWYgKHN0YXRlKQo+ICsJCWRybV9h dG9taWNfc3RhdGVfcHV0KHN0YXRlKTsKPiArCj4gKwlkcm1fbW9kZXNldF9kcm9wX2xvY2tzKCZj dHgpOwo+ICsJZHJtX21vZGVzZXRfYWNxdWlyZV9maW5pKCZjdHgpOwo+ICsKPiArCXJldHVybiBy ZXQ7Cj4gK30KPiArRVhQT1JUX1NZTUJPTChkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0b3JfbW9k ZXNldCk7Cj4gKwo+ICsvKioKPiAgICogZHJtX2F0b21pY19oZWxwZXJfYmVzdF9lbmNvZGVyIC0g SGVscGVyIGZvciAmZHJtX2Nvbm5lY3Rvcl9oZWxwZXJfZnVuY3MKPiAgICogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgLT5iZXN0X2VuY29kZXIgY2FsbGJhY2sKPiAgICogQGNvbm5l Y3RvcjogQ29ubmVjdG9yIGNvbnRyb2wgc3RydWN0dXJlCj4gZGlmZiAtLWdpdCBhL2luY2x1ZGUv ZHJtL2RybV9hdG9taWNfaGVscGVyLmggYi9pbmNsdWRlL2RybS9kcm1fYXRvbWljX2hlbHBlci5o Cj4gaW5kZXggN2ZmOTJiMC4uOGRlMjRkYyAxMDA2NDQKPiAtLS0gYS9pbmNsdWRlL2RybS9kcm1f YXRvbWljX2hlbHBlci5oCj4gKysrIGIvaW5jbHVkZS9kcm0vZHJtX2F0b21pY19oZWxwZXIuaAo+ IEBAIC0xMjYsNiArMTI2LDcgQEAgaW50IGRybV9hdG9taWNfaGVscGVyX3BhZ2VfZmxpcChzdHJ1 Y3QgZHJtX2NydGMgKmNydGMsCj4gIAkJCQl1aW50MzJfdCBmbGFncyk7Cj4gIGludCBkcm1fYXRv bWljX2hlbHBlcl9jb25uZWN0b3JfZHBtcyhzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9y LAo+ICAJCQkJICAgICBpbnQgbW9kZSk7Cj4gK2ludCBkcm1fYXRvbWljX2hlbHBlcl9jb25uZWN0 b3JfbW9kZXNldChzdHJ1Y3QgZHJtX2Nvbm5lY3RvciAqY29ubmVjdG9yKTsKPiAgc3RydWN0IGRy bV9lbmNvZGVyICoKPiAgZHJtX2F0b21pY19oZWxwZXJfYmVzdF9lbmNvZGVyKHN0cnVjdCBkcm1f Y29ubmVjdG9yICpjb25uZWN0b3IpOwoKLS0gCkphbmkgTmlrdWxhLCBJbnRlbCBPcGVuIFNvdXJj ZSBUZWNobm9sb2d5IENlbnRlcgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9p bnRlbC1nZngK